Audit 762R guns for volume, and longest_side #42817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase volume 5.6%, following the weight increase factor
Increase volume by the same factor as weight (5.75%)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Audit 7.62R guns for volume, and longest_side"
Purpose of change
Contribute to #37374 and #41691
Describe the solution
Update the JSON file the calculated values, from the method described in #37374
Testing
Test suite passes. JSON validates. Guns are spawnable in-game without any problems.
Additional context
If found one source that stated the general width of these rifles to be 43 mm. Apparently, they varied in width, depending on the stock and other things (up to 46 mm, according to the source here: https://www.internationalsportsman.com/classic-arms-review-mosin-nagant-m91-30/). I used the lower 43 mm value.
Mosin-Nagant 1891/30
Basic data + references:
https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A116
Mosin-Nagant 1891/30-EBR
For the EBR variant, I simply increased the given volume by the same amount as weight,
longest_sideremains the same.Mosin-Nagant M44
Basic data + references:
https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A118
Mosin-Nagant M44-EBR
For the EBR variant, I simply increased the given volume by the same amount as weight,
longest_sideremains the same.