Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steel rail ammo density is too high. #43156

Closed
TheMasterGear opened this issue Aug 23, 2020 · 3 comments · Fixed by #43166
Closed

Steel rail ammo density is too high. #43156

TheMasterGear opened this issue Aug 23, 2020 · 3 comments · Fixed by #43166
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON stale Closed for lack of activity, but still valid.

Comments

@TheMasterGear
Copy link
Contributor

While checking steel density I found that the material density fluctuated hugely depending on the item. The rail is one of the worst having a g/cm3 of 80!

Steps To Reproduce

  1. Look at a steel rails weight and liters volume
  2. 1 liter = 1000 cm3, so 1600 cm3/ 20 cm3= 80 g/cm3

Expected behavior

Density similar too steel

Screenshots

steel rail

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.E-5001-gec1deea [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]
@anothersimulacrum anothersimulacrum added [JSON] Changes (can be) made in JSON Good First Issue This is a good first issue for a new contributor labels Aug 23, 2020
@Alex-Folts
Copy link
Contributor

I found that the material density fluctuated hugely depending on the item.

Just to make it clear.
You probably confused volume of complex shape object and volume of material this object made.
Volume here mostly used for inventory system, to make sure object will fit and how many objects will fit.
Ofc if density of steel object is higher than density of steel itself - it would be bug, but not always lower density is a bug. Less density usually is fine unless you have solid cube/cubiod.
While your changes seems fine in this case, keep in mind that this ultra precise mass to volume ratios not always hold for real objects.

@TheMasterGear
Copy link
Contributor Author

I found that the material density fluctuated hugely depending on the item.

Just to make it clear.
You probably confused volume of complex shape object and volume of material this object made.
Volume here mostly used for inventory system, to make sure object will fit and how many objects will fit.
Ofc if density of steel object is higher than density of steel itself - it would be bug, but not always lower density is a bug. Less density usually is fine unless you have solid cube/cubiod.
While your changes seems fine in this case, keep in mind that this ultra precise mass to volume ratios not always hold for real objects.

Yeah, that's why I think it'll only work with an object that is only one material and is compacted in shape. Arrow and other ammo will have to be done differently, which what we'll need to find out one day.

@stale
Copy link

stale bot commented Sep 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants