Reworked rebar and rebar rail into rebar no.5 (First time contribution) #43166
Conversation
Corrected rebar and rail into steel, and normalized density and volume into the density of high carbon steel. 7.85 g/cm3 https://www.harrissupplysolutions.com/5-rebar.html Also changed rebar spear not to have a reach attack, much like the pointed stick because they are both short for spears, 80 cms.
TheMasterGear
changed the title
TheMasterGear
changed the title
This reverts commit 08f84e8.
Revered copy-from back to rebar_rail
Fixed volume of the steel rail.
Redone recalculation of both rails weight and volume to be as close to 7.85 g/cm3 as possible. Plus, I shaved off weight and volume to the steel rail to be thinner and lighter than rebar rail by 10%.
|
Gosh, I totally butchered getting the file up here cleanly. Sorry! Is there a way to run the game without changing the files by compiling it? |
|
I'm not sure what you're asking. |
I used Microsoft Visual Studio to compile the GitHub version of the game to test the patch, but it changes the files slightly so I had to use a different copy of the game to test which got confusing. |
|
Ah, that's weird. Well, for working on this you can just not add them (untick the checkmark there), but you should probably make an issue or seek help outside of this PR about that. |
Yeah, it might be that my CMake has an error. It works also found that rail's in the JSON are ten of them when I did that calculation for only one rail so they're basic weightless now. This needs to be fixed. |
Fixed the volume to work as the item comes in a stack of ten.
JSON Web Linting Tool
|
It's still failing. I'm not sure what's left to fix? |
|
None of the CI failures are your fault. |
Just out of curiosity, what when wrong then? |
|
Something changed the DPS of a melee weapon. |
Just out of curiosity, what when wrong then?
Will I need to update my branch once this is fixed? |
|
Nope, CI failures that are not your fault won't cause problems for you. |
|
Actually the test failure is related, it increased the DPS of rebar |
|
Whoops, missed that. I saw the header above it said club, so I thought it was that. |
|
I read it that way the first time too.
…On Sat, Sep 5, 2020, 2:16 PM anothersimulacrum ***@***.***> wrote:
Whoops, missed that. I saw the header above it said club, so I thought it
was that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43166 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGSA5DYY4B3SHPZLVXTDGTSEKTDTANCNFSM4QI5UGFA>
.
|
|
Did the weight change to rebar melee need to be changed back? |
|
Probably the test needs to be changed. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
|
Crap, I will fix this the test I promise. |
Summary
SUMMARY: Balance "Corrected rebar and rail into steel, and normalized density and volume"
Purpose of change
Fixes #43156
Describe the solution
Corrected rebar and rail into steel, and normalized density and volume into the density of high carbon steel. 7.85 g/cm3 to match steel rebar type no.5
Also changed rebar spear not to have a reach attack, much like the pointed stick because they are both short for spears, 80 cms.
Describe alternatives you've considered
Could also be type no.4, no.6, or any other imperial bar size. But it's most common for no.5 rebar to be inside roadways, which is where you get rebar in CDDA.
Testing
Spawn rebar and looked at the crafting menu. Made sharpened rebar and rail rebar 1% and 5% lighter for being sharpened to points and one bar of rebar makes 5 rails.