Changing engagement rules for an NPC makes them unresponsive to enemies

[Zreks]

Describe the bug

After changing engagement rules the NPC doesn't seek out enemies anymore and just stands in place if there are enemies, even if the rule set allows them to move. Before changing the engagement rules the NPC works fine, only breaks afterwards.

Steps To Reproduce

1. Recruit NPC
2. Don't assign any engagement rules he will work fine
3. Change rules to anything
4. No longer moves to attack anyone

Expected behavior

The NPC should be able to move after changing rules, but doesn't and can only attack enemies next to them.

Versions and configuration

• OS: Windows
  • OS Version: 10.0 2004
• Game Version: 0.E-7587-g8d87f15 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Bionic Professions [package_bionic_professions],
  Graphical Overmap [Graphical_Overmap]
  ]

Additional context

I have npc needs mod enabled, but it does the same without it.

[Theawesomeboophis]

Did you tell them to avoid conflict, what did you change their engagement rules to?

[Zreks]

No matter what I change it to, it always happens, they will follow me around but not move to attack even if i tell them they can freely attack what they want Theawesomeboophis <notifications@github.com> (időpont: 2020. nov. 17., K, 21:19) ezt írta:

…

Did you tell them to avoid conflict, what did you change their engagement rules to? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#45470 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJHJXIITSLG6PRU252BURLSQLLFJANCNFSM4TYY4D5Q> .

[Zreks]

But the first thing I tried was only attack enemies I attack, maybe that matters, it doesnt matter which setting I try after that the same thing happens György Polgár <zrexblue@gmail.com> (időpont: 2020. nov. 18., Sze, 4:18) ezt írta:

…

No matter what I change it to, it always happens, they will follow me around but not move to attack even if i tell them they can freely attack what they want Theawesomeboophis ***@***.***> (időpont: 2020. nov. 17., K, 21:19) ezt írta: > Did you tell them to avoid conflict, what did you change their engagement > rules to? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#45470 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFJHJXIITSLG6PRU252BURLSQLLFJANCNFSM4TYY4D5Q> > . >

[Theawesomeboophis]

Ok, It might be an AI problem.

…

On Nov 17, 2020 10:21 PM, "Zreks" ***@***.***> wrote: But the first thing I tried was only attack enemies I attack, maybe that matters, it doesnt matter which setting I try after that the same thing happens György Polgár ***@***.***> (időpont: 2020. nov. 18., Sze, 4:18) ezt írta: > No matter what I change it to, it always happens, they will follow me > around but not move to attack even if i tell them they can freely attack > what they want > > Theawesomeboophis ***@***.***> (időpont: 2020. nov. 17., K, > 21:19) ezt írta: > >> Did you tell them to avoid conflict, what did you change their engagement >> rules to? >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/CleverRaven/Cataclysm-DDA/ issues/45470#issuecomment-729177793>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/ AFJHJXIITSLG6PRU252BURLSQLLFJANCNFSM4TYY4D5Q> >> . >> > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#45470 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARDXS522ORJRC3DZONE4YY3SQM4SBANCNFSM4TYY4D5Q> .

[inverimus]

I think @Zreks is experiencing the same bug as me, but the problem is not caused by setting the engagement rules. After some time with you an NPC follower just breaks and always acts as if they are only allowed to attack enemies without moving no matter what the engagement rules are set to. This has happened the last 3 games I have gotten the starting NPC to join me.

I can spawn in an NPC and modify their engagement rules and they work fine up until "something" happens that breaks it. It seems to usually take a couple of in game weeks before it happens so it isn't easy to test it.

I was going to provide a save with a broken NPC, but while testing I was able to "fix" him. I think it may have been by toggling the "move freely" option off and back on. Note that the broken NPC behavior was not as if this was set to "stick close no matter what" as this option normally still allows them to move to attack just not move more than 2 spaces away from you. When they are broken they will only attack enemies that come within melee range of them and otherwise only follow you.

[RadHazard]

I'm still seeing what I think is this bug as of a few days ago. I think I might have some hint as to what's going on: When I engage zombies, my NPC occasionally says "What was that?" and other lines about hearing noises despite being only two tiles away.

It seems like she's having trouble seeing, and I'm not sure why -- I can confirm my NPC doesn't have any vision-related traits, she's not wearing a blindfold, and her character sheet doesn't mention any vision-related conditions. I've got two guesses, but no idea which one is right:

1. NPCs are going blind (or being buggily treated as such despite not being blind) for some reason. This would explain why they can easily hit enemies next to them but won't move to fight.
2. NPCs vision range is not correctly centred on them. The reason I suspect this might be the case is that I've occasionally witnessed my NPC do really weird things. She'll start chasing a corpse three map tiles away to pulp it, or she'll run away try to engage off-screen enemies when posted on guard duty.

EDIT: To add onto this, I just tested it and it seems like the problem goes away after a reload. This would make sense if it's some kind of issue with vision getting out-of-sync with the NPC.

EDIT 2: It looks like the issue we're seeing is actually #43079. I'm not going to call this a duplicate without confirmation from OP that that's the same problem, but I'm moving my findings there