Kevlar dog harness cannot be butchered or disassembled

[10asd28]

This item that is typically dropped from K-9s cannot be broken down to its base components.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[merrygin]

This (and other items) is flagged with NO_SALVAGE, i suspect because former contributors intended to add specific uncraft recipes but didn't end up creating some, see #29134. They described problems with removing NO_SALVAGE:
"NO_SALVAGE applied to leather harness (gave back way too much rags and leather patches for some reason) and rainsuit (yielded neoprene sheets)"
So this issue would probably need a specific uncraft recipe.

[leemuar]

NO_SALVAGE applied to leather harness (gave back way too much rags and leather patches for some reason) and rainsuit (yielded neoprene sheets)

As far as I remember "gave back way more rags and leather" is a bug and it applies to many other items. I think we should fix the bug and remove the NO_SALVAGE flag from items.

[merrygin]

That would be ideal of course! I don't see an open issue for that, though, and have no idea how difficult the problem actually is.
If its a big problem that requires a lot of time, it would still be sensible to get some easy recipe working in the meantime, i think.

[leemuar]

That would be ideal of course! I don't see an open issue for that, though, and have no idea how difficult the problem actually is.
If its a big problem that requires a lot of time, it would still be sensible to get some easy recipe working in the meantime, i think.

#45063 and #42375. The bug was actually fixed and merged. We can now review the problem again and probably remove NO_SALVAGE flag from dog's armor

[leemuar]

I did some test and it seems there is a new bug that still increases amount of materials on salvaging (more details here: #45779 (comment))

On current stable Ellison version disassembling Kevlar dog harness gives 6 layered kevlar plates
On the most current version of the game (tested on cb88af7) - 50+ layered kevlar plates

Im not very experienced with the game, but that amount (50+) looks kinda wrong.

The "bug" (huge amount of materials out of cutting\disassembling items) comes from algo that tries it's best to calculate materials based on item's mass. If the item is heavy - it will generate much more materials out of it.

Figuring out the correct algo will be tricky and requires time. A quicker solution would be to add uncraft recipes manually as @merrygin suggested.

[actual-nh]

I suspect part of the problem is that the only material listed is kevlar_layered, when in actuality there would be other materials involved. Admittedly, given how armor works, adding an extra material (nylon, I suspect) will require increasing the thickness if the current level of armoring is realistic - I don't know if it is (might be too protective for reality).

[leemuar]

@ZhilkinSerg mentioned here that this might be OK behavior. Increased material yield might be a new norm and the "old" yield was actually incorrect and too low

Im too new to the game to judge, but if it is true - then we can just remove NO_SALVAGE flag without making new uncraft recipe for this issue. Could someone please confirm that this new increased amount of materials is correct?

[actual-nh]

Im too new to the game to judge, but if it is true - than we can just remove NO_SALVAGE flag without making new uncraft recipe for this issue. Could someone please confirm that this new increased amout of materials is correct?

I suggest creating a pull request and seeing what people think. (Put '[CR]' in the tile to request further comment, and I can request ZhilkinSerg as a reviewer.)

[leemuar]

What also bothers me: Kevlar dog harness yields almost twice as much kevlar plates (50+) than Kevlar vest (30+). Is dog's vest really twice as heavy as human's?

[Alienmen1]

With the current experimental version. Kevlar Dog Harness cannot be disassembled or butchered.
Also what leemuar said is right, the kevlar dog harness shouldn't give more plate than an actual human kevlar vest

[leemuar]

Ill make another issue for auditing kevlar armor yield

[leemuar]

The correct way to solve this is to add uncraft recipes for all dog's armor. See #50007 (comment) for the details why removing NO_SALVAGE flag is not enough

[captainego]

After reviewing the dog harnesses there were only two that did not have uncraft recipes. I have added uncraft recipes for leather_harness_dog (leather dog harness) and rubber_harness_dog (rubber dog rainsuit) . leather_harness_dog returns up to 3 leather patches and rubber_harness_dog returns up to 8 cotton sheets and 8 plastic sheets.

Both require a cutting tool of 2