Flying Polyp attacks spam z-level view violation

[pehamm]

Describe the bug

Whenever a flying polyp is above an entity it is hostile to, it can try to attack the enemy below triggering a debug message "Z-level view violation: the flying polyp tried to attack the [monster]". In lab starts with tears in reality, this can quickly get spammy.

Reproduced with the latest experimental and the first 0.F candidate.

Steps To Reproduce

1. Find or spawn a monster horde
2. Spawn a flying polyp a Z-level above them
3. Await the error messages

Expected behavior

No errors when polyps are attacking.

Versions and configuration

• OS: MacOs
  • OS Version: Name: Mac OS X; Version: 10.14.6; Build: 18G6020;
• Game Version: 0.E-10519-g272a1d4244 [64-bit]
• Graphics Version: Tiles
• Game Language: System language [] (en-US)
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Bionic Professions [package_bionic_professions]
  ]

[Xindage]

I can confirm that happened to me too but with a different creature, a zombie raptor comes from a second floor from a building and was trying to attack me relentlessly, the debug messages just stopped only when i got on the second floor myself and i killed it.
The attacks actually fail but the debug messages keep coming.
Note: For me this glitch happened in the middle of a road so i dont think that's is just limited to labs.

[Anaglyphic]

Same. it's happened a few times... latest was z-level violation polyp trying to hit a technician zed but not connecting this was linux 10488, 11524, and checkout tag: cdda-jenkins-b11582,.. last times I just ignored it, but this time for some reason it bugged me, same solution as Xin, found the tech zed standing there doing nothing, I guess "attacking up" to defend but we can't visually see that... went onto a nearby 2-story apt building's roof and shot polyp til it evaporated. This was over a 'public park' tile in an urban area. No labs or portals visible or searchable on map either. Guessing this one will have lots of "me too!" soon as the weekend gets here.

[Maleclypse]

#48245 Did this close this issue?

[pehamm]

Pretty sure it did not, the linked commit was merged in April and the issue was present in builds from May. I will check whether I can still replicate with current builds once I get home.

[actual-nh]

For now, removal of the debug message will do for 0.F. In the future, some looks at diverting monsters from trying impossible melee attacks (and using up moves) will be desirable.

[pehamm]

Could not replicate on the current experimental. Could be that #48816 fixed this as well, not 100% sure on that. This should be safe to close, it's not like inconsequential warning messages are game-breaking.

[YehnBeep]

I've been getting this a lot with wasps on version ae2ff5c .

09:56:46.309 ERROR : (error message will follow backtrace)
  #0
    (dbghelp: @0x7ff75c3f11b4[cataclysm-tiles.exe+0x2211b4]), 
    (libbacktrace: debug_write_backtrace(std::ostream&)+0x9e@0x1402211b4),
    0x1402211b4    src/debug.cpp:1114    debug_write_backtrace(std::ostream&)
  #1
    (dbghelp: @0x7ff75c3f288c[cataclysm-tiles.exe+0x22288c]), 
    (libbacktrace: DebugLog(DebugLevel, DebugClass)+0x20e@0x14022288c),
    0x14022288c    /opt/mxe/usr/x86_64-w64-mingw32.static.gcc11/include/time.h:230    time
    0x14022288c    src/debug.cpp:1442    DebugLog(DebugLevel, DebugClass)
  #2
    (dbghelp: @0x7ff75c3f38e6[cataclysm-tiles.exe+0x2238e6]), 
    (libbacktrace: realDebugmsg(char const*, char const*, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x1ac@0x1402238e6),
    0x1402238e6    src/debug.cpp:505    realDebugmsg(char const*, char const*, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
  #3
    (dbghelp: @0x7ff75c88e6c1[cataclysm-tiles.exe+0x6be6c1]), 
    (libbacktrace: monster::melee_attack(Creature&, float)+0x12b@0x1406be6c1),
    0x1406be6c1    /opt/mxe/usr/lib/gcc/x86_64-w64-mingw32.static.gcc11/11.2.0/include/c++/bits/basic_string.h:671    std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::~basic_string()
    0x1406be6c1    src/debug.h:78    void realDebugmsg<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(char const*, char const*, char const*, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)
    0x1406be6c1    src/monster.cpp:1621    monster::melee_attack(Creature&, float)
  #4
    (dbghelp: @0x7ff75c882d4d[cataclysm-tiles.exe+0x6b2d4d]), 
    (libbacktrace: monster::move()+0x10f1@0x1406b2d4d),
    0x1406b2d4d    src/monmove.cpp:1062    monster::move()
  #5
    (dbghelp: @0x7ff75c43ed04[cataclysm-tiles.exe+0x26ed04]), 
    (libbacktrace: do_turn()+0xdec@0x14026ed04),
    0x14026ed04    src/do_turn.cpp:458    monmove
    0x14026ed04    src/do_turn.cpp:787    do_turn()
  #6
    (dbghelp: @0x7ff75d722ecd[cataclysm-tiles.exe+0x1552ecd]), 
    (libbacktrace: main+0x16e8@0x141552ecd),
    0x141552ecd    src/main.cpp:789    main
  #7
    (dbghelp: @0x7ff75c1d13c1[cataclysm-tiles.exe+0x13c1]), 
    (libbacktrace: _tmainCRTStartup+0x231@0x1400013c1),
    0x1400013c1    /opt/mxe/tmp-gcc-x86_64-w64-mingw32.static.gcc11/gcc-11.2.0.build_/mingw-w64-v9.0.0/mingw-w64-crt/crt/crtexe.c:323    __tmainCRTStartup
  #8
    (dbghelp: @0x7ff75c1d14d6[cataclysm-tiles.exe+0x14d6]), 
    (libbacktrace: WinMainCRTStartup+0x16@0x1400014d6),
    0x1400014d6    /opt/mxe/tmp-gcc-x86_64-w64-mingw32.static.gcc11/gcc-11.2.0.build_/mingw-w64-v9.0.0/mingw-w64-crt/crt/crtexe.c:178    WinMainCRTStartup
  #9
    (dbghelp: BaseThreadInitThunk+0x14@0x7ff95e247034[KERNEL32.DLL+0x17034]), 
    (backtrace_syminfo failed: errno = -1, msg = no symbol table in PE/COFF executable),
    (backtrace_pcinfo failed: errno = -1, msg = no debug info in PE/COFF executable),
  #10
    (dbghelp: RtlUserThreadStart+0x21@0x7ff95f1a2651[ntdll.dll+0x52651]), 
    (backtrace_syminfo failed: errno = -1, msg = no symbol table in PE/COFF executable),
    (backtrace_pcinfo failed: errno = -1, msg = no debug info in PE/COFF executable),
Backtrace emission took 0 seconds.
(continued from above) ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the swollen wretch tried to attack the giant wasp guard.
09:56:58.859 ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the swollen wretch tried to attack the giant wasp guard.
09:57:20.267 ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the swollen wretch tried to attack the giant wasp guard.

10:10:05.774 ERROR : (error message will follow backtrace)
  #0
    (dbghelp: @0x7ff75c3f11b4[cataclysm-tiles.exe+0x2211b4]), 
    (libbacktrace: debug_write_backtrace(std::ostream&)+0x9e@0x1402211b4),
    0x1402211b4    src/debug.cpp:1114    debug_write_backtrace(std::ostream&)
  #1
    (dbghelp: @0x7ff75c3f288c[cataclysm-tiles.exe+0x22288c]), 
    (libbacktrace: DebugLog(DebugLevel, DebugClass)+0x20e@0x14022288c),
    0x14022288c    /opt/mxe/usr/x86_64-w64-mingw32.static.gcc11/include/time.h:230    time
    0x14022288c    src/debug.cpp:1442    DebugLog(DebugLevel, DebugClass)
  #2
    (dbghelp: @0x7ff75c3f38e6[cataclysm-tiles.exe+0x2238e6]), 
    (libbacktrace: realDebugmsg(char const*, char const*, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x1ac@0x1402238e6),
    0x1402238e6    src/debug.cpp:505    realDebugmsg(char const*, char const*, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
  #3
    (dbghelp: @0x7ff75c88e6c1[cataclysm-tiles.exe+0x6be6c1]), 
    (libbacktrace: monster::melee_attack(Creature&, float)+0x12b@0x1406be6c1),
    0x1406be6c1    /opt/mxe/usr/lib/gcc/x86_64-w64-mingw32.static.gcc11/11.2.0/include/c++/bits/basic_string.h:671    std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::~basic_string()
    0x1406be6c1    src/debug.h:78    void realDebugmsg<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(char const*, char const*, char const*, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&)
    0x1406be6c1    src/monster.cpp:1621    monster::melee_attack(Creature&, float)
  #4
    (dbghelp: @0x7ff75c882d4d[cataclysm-tiles.exe+0x6b2d4d]), 
    (libbacktrace: monster::move()+0x10f1@0x1406b2d4d),
    0x1406b2d4d    src/monmove.cpp:1062    monster::move()
  #5
    (dbghelp: @0x7ff75c43ed04[cataclysm-tiles.exe+0x26ed04]), 
    (libbacktrace: do_turn()+0xdec@0x14026ed04),
    0x14026ed04    src/do_turn.cpp:458    monmove
    0x14026ed04    src/do_turn.cpp:787    do_turn()
  #6
    (dbghelp: @0x7ff75d722ecd[cataclysm-tiles.exe+0x1552ecd]), 
    (libbacktrace: main+0x16e8@0x141552ecd),
    0x141552ecd    src/main.cpp:789    main
  #7
    (dbghelp: @0x7ff75c1d13c1[cataclysm-tiles.exe+0x13c1]), 
    (libbacktrace: _tmainCRTStartup+0x231@0x1400013c1),
    0x1400013c1    /opt/mxe/tmp-gcc-x86_64-w64-mingw32.static.gcc11/gcc-11.2.0.build_/mingw-w64-v9.0.0/mingw-w64-crt/crt/crtexe.c:323    __tmainCRTStartup
  #8
    (dbghelp: @0x7ff75c1d14d6[cataclysm-tiles.exe+0x14d6]), 
    (libbacktrace: WinMainCRTStartup+0x16@0x1400014d6),
    0x1400014d6    /opt/mxe/tmp-gcc-x86_64-w64-mingw32.static.gcc11/gcc-11.2.0.build_/mingw-w64-v9.0.0/mingw-w64-crt/crt/crtexe.c:178    WinMainCRTStartup
  #9
    (dbghelp: BaseThreadInitThunk+0x14@0x7ff95e247034[KERNEL32.DLL+0x17034]), 
    (backtrace_syminfo failed: errno = -1, msg = no symbol table in PE/COFF executable),
    (backtrace_pcinfo failed: errno = -1, msg = no debug info in PE/COFF executable),
  #10
    (dbghelp: RtlUserThreadStart+0x21@0x7ff95f1a2651[ntdll.dll+0x52651]), 
    (backtrace_syminfo failed: errno = -1, msg = no symbol table in PE/COFF executable),
    (backtrace_pcinfo failed: errno = -1, msg = no debug info in PE/COFF executable),
Backtrace emission took 0 seconds.
(continued from above) ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the wasp guard tried to attack the shocker zombie.
10:10:12.273 ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the wasp guard tried to attack the shocker zombie.
10:10:14.478 ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the wasp guard tried to attack the shocker zombie.
10:10:16.982 ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the wasp guard tried to attack the shocker zombie.
10:10:21.599 ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the wasp guard tried to attack the shocker zombie.
10:10:25.010 ERROR : src/monster.cpp:1621 [bool monster::melee_attack(Creature&, float)] Z-Level view violation: the wasp guard tried to attack the cockroach.

 DEBUG    : Z-Level view violation: the wasp guard tried to attack the cockroach.

 FUNCTION : bool monster::melee_attack(Creature&, float)
 FILE     : src/monster.cpp
 LINE     : 1621
 VERSION  : 32ee0b1