Crafting search filter won't show up

[Maryionet]

Describe the bug

The crafting search filter ui won't show up when i try to click the (f) button i can still search things do

Steps To Reproduce

1 go to crafting by (&)
2 click (f) for search filter

Expected behavior

It should show the search filter ui when i click (f)

Screenshots

Versions and configuration

• OS: Android
  • OS Version: Manufacturer: realme; Model: RMX3241; Release: 11; Incremental: 1620697410778;
• Game Version: 3b51b62 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions]
  ]

Additional context

No response

[dseguin]

Your screen doesn't display enough rows, so the filter window is technically spawning off-screen. You can try reducing your font size and font height a little bit to display more rows:

A more proper solution would involve setting the window's origin based on the number of rows.

[Maryionet]

@dseguin i tried your solution but the filter still won't show but from my testing it appears that the search filter does show on older versions.
and i'm not sure if this is related to the issue but when i start the game this white square appears and i don't see this on older versions were the filter appears.

[hexagonrecursion]

Possibly related: #48700

[Maryionet]

@hexagonrecursion

It is related in that the search filter ui failed show but i checked and i tried his method of increasing the terminal height to 26 and it works.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[ZeroInternalReflection]

This can be 'fixed' by compressing the filter help text a bit:

But the root cause is that string_input_popup doesn't error-check whether the resulting window is going to be too big for the terminal (string_input_popup.cpp). I'm guessing this screen is a bit more involved than was envisioned when it was developed.

Since the crafting filter screen probably isn't getting less complicated anytime soon, I think the ideal solution is adding the ability to scroll to string_input_popup windows.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.