Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Occured on Fresh Start while Walking through field by swamp. #54603

Closed
JonathanLochridge opened this issue Jan 20, 2022 · 4 comments · Fixed by #54632
Closed

Error Occured on Fresh Start while Walking through field by swamp. #54603

JonathanLochridge opened this issue Jan 20, 2022 · 4 comments · Fixed by #54632
Labels
<Bug> This needs to be fixed Monsters Monsters both friendly and unfriendly.

Comments

@JonathanLochridge
Copy link
Contributor

Describe the bug

Error Occurred on Fresh Start while Walking through field by swamp. After finding and looting a single item from a non-zombie body.
'''
DEBUG : tried to put an item (blazer) count (1) in a container (null) that cannot contain it: pocket with type (CONTAINER) not found

FUNCTION : ret_val item::put_in(const item&, item_pocket::pocket_type, bool)
FILE : src/item.cpp
LINE : 1399
VERSION : d740104
'''

Steps to reproduce

  1. Make player
  2. Walk by field by swamp
  3. Keep going till you find a corpse.
  4. Hope you can actually see the debug message

Expected behavior

To not get a debug message.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: d740104 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language (English)
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

No response
@NetSysFire
Copy link
Member

This looks oddly similar to #53785

@JonathanLochridge
Copy link
Contributor Author

Maybe it's the same bug form. But I didn't see any zombies in sight at the time?

@NetSysFire
Copy link
Member

Make sure there are no craters near you

@NetSysFire NetSysFire added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 21, 2022
gruebite added a commit to gruebite/Cataclysm-DDA that referenced this issue Jan 21, 2022
@gruebite
Update monster deaths to return nullptr
36b91ac 
Fixes an issue when a corpse can't be created, which should return a
nullptr, not a null item.

fixes CleverRaven#53785, fixes CleverRaven#54603
@gruebite gruebite mentioned this issue Jan 21, 2022
Merged
@NetSysFire
Copy link
Member

@JonathanLochridge If you know how, try using the patch mentioned just above and see if that fixes your issue

kevingranade pushed a commit that referenced this issue Jan 21, 2022
@gruebite @BrettDong
Update monster deaths to return nullptr (#54632)
5ac1a12 
Fixes an issue when a corpse can't be created, which should return a
nullptr, not a null item.

fixes #53785, fixes #54603

Co-authored-by: Binrui Dong <brett.browning.dong@gmail.com>
@NetSysFire NetSysFire added <Bug> This needs to be fixed Monsters Monsters both friendly and unfriendly. and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Monsters Monsters both friendly and unfriendly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update monster deaths to return nullptr gruebite/Cataclysm-DDA
2 participants
@JonathanLochridge @NetSysFire