Fish caught by fish traps rot too fast

[mqrause]

Describe the bug

Fish traps produce up to 5 dead fish with an age between 0-3 hours 3 hours after they've been set. If you're not around to butcher the fish right away, chances are high you lose out on a lot of fish because it's rotten once you're done butchering.

Steps to reproduce

1. Set up a fish trap (high survival skill recommended for multiple fish caught)
2. Wait for a few more than 3 hours (e.g. sleep while the trap does its catching)
3. See rotten fish, or fish that produce rotten fillets when butchered, depending on how much time passed and how old the fish were when spawned

Expected behavior

From my understanding, these kinds of trap catch live fish, so they should only start rotting the moment you extract them from the trap/extract the trap from the water, giving you enough time to process them.

Screenshots

No response

Versions and configuration

cc694a8

Additional context

No response

[RoyBerube]

Cataclysm-DDA/src/iuse.cpp

Lines 1903 to 1905 in 9ac0fc9

	here.add_item_or_charges( pos, item::make_corpse( chosen_fish->type->id,
	calendar::turn + rng( 0_turns,
	3_hours ) ) );

Take away the time rng from make_corpse() and the fish would be fresh.

[mqrause]

While that certainly improves the situation, I wouldn't consider it a real solution for the issue.

[chrispikula]

Maybe the fish trap could fake leashing fish with radius zero? You'd still have to kill the fish. This would prevent multiple fish from being in the fish trap, though, as monsters can't stack.

[mqrause]

Well, the basket fish trap is 12 liters, so I would assume a bunch of fish would fit in there (depending on their size of course). I was thinking maybe it could be more appropriately implemented as a an actual trap or a furniture that allows you to extract the fish by examining, spawning fresh fish at that moment.
Though the current code explicitly mentions it's done as it is for the convenience of not having to interact with the item after setting it down. But I don't exactly agree with that for the reason of this issue.