New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basket fish trap doesn't seem to work outside the reality bubble #62151
Comments
I pretty sure that it did work when I made #58549. Haven't used traps much since then, though. |
This is the first time I've tried to do so (after first making a net, only to find that it can't actually be used for its primary purpose). Fishing isn't critical to my character, so it's just an annoyance to me, but I still think it should be reported. Edit: |
Line 1838 in 4ea1c29
The logic is after that. Fish traps aren't actual traps, they're just items that do stuff after a timer ticks down. As far as I can see success only depends on your survival skill. But spawning actual fish in the trap seems to depend on nearby fish monsters in a waterbody connected to the place of the fish trap (radius 60, independent of reality bubbly), with just a 5% chance |
Tested to teleport to my little "definitely fish here" pond, set a trap, and just pressed wait for 3 hours, moving some 5 in-game tiles away until it got too dark, after which I moved to two tiles away. When the trap triggered it contained 5 fish, so there's something fishy going on. |
Can you attach a save with your test pond? |
I'll try. I think I'll have to shrink the save to fit, though, but it should be possible. |
Standing by the pond, trap in inventory: |
So it seems the code looking for fishable monsters is the issue somehow. The fishable locations are detected properly, but it can't find any of the fish in the pond. Teleporting on top of it from far away even leaves the list of monsters to check completely empty. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Related/duplicate: #48485 If one is resolved in the future both should likely be considered resolved |
Describe the bug
I made a basket fish trap, made bait for it, and placed it in various places about a dozen time without catching anything at all, while still losing bait. Only one place stated that I wouldn't have much luck, while another, tried several times, had 3 visible fish in a rather small shallow pond of a size 5*4 tiles or so.
In all of these attempts I moved to the body of water, set the trap, and then returned to do whatever I needed to do elsewhere, checking back after a number of hours (at most the next day).
The only time I actually did catch anything was when I placed the trap two (in-game) tiles away from the PC extracting clay on a river bank.
Steps to reproduce
Expected behavior
The trap should work regardless of whether it's in the reality bubble or not when it times out. That's sort of the point of a passive trap.
Screenshots
No response
Versions and configuration
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions],
Innawood [innawood]
]
Additional context
My PC's Survival skill is 8, which I think should be sufficient.
The text was updated successfully, but these errors were encountered: