Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monsters GitHub label doesn't get applied when monsters are being touched directly #72746

Open
Karol1223 opened this issue Mar 31, 2024 · 4 comments
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Karol1223
Copy link
Contributor

Describe the bug

As in the title - the label doesn't get automatically assigned when monster JSON is being touched. It does get applied occasionally for other things, though, such as editing monster factions.

Attach save file

N/A

Steps to reproduce

  1. Look at any PR that touches only monster JSON files
  2. No label
  3. Cry

Expected behavior

Touching monster JSON directly should apply the monsters label to the PR

Screenshots

No response

Versions and configuration

N/A

Additional context

My attempts at solving this in #71933 brought no results

@Karol1223 Karol1223 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 31, 2024
@Procyonae
Copy link
Contributor

"Look at any PR that touches only monster JSON files" You got any example ones? '^^ I can't find any

@Karol1223
Copy link
Contributor Author

"Look at any PR that touches only monster JSON files" You got any example ones? '^^ I can't find any

#72700 #72534 #71752 #71741

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 30, 2024
@GuardianDll GuardianDll added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Apr 30, 2024
@harakka
Copy link
Contributor

harakka commented Apr 30, 2024

/confirm

@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

4 participants