-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Board up window" shows no missing requirements but I cannot build it. #73328
Comments
The first one (in the JSON file) requires a window with the flag BARRICADABLE_WINDOW, The issue is then to figure out what kind of starting tile you have, why it doesn't match any of these criteria, and define a new "recipe" matching your criteria. The task should reasonably also look for other missed cases (assuming your starting tile is reasonable to board up, which I assume it is). |
The only time I can see it not allowing you is when there's no window right next to you |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
It is not, I was standing in the middle of the room.
Yes that is what this issue is about. I see I wasn't clear. My problem is that it should tell me "You need to be next to (some kind of) a window." But it doesn't. It doesn't state any requirements on a tile. The player should see the recipe including all the requirements. Not omiting that (some kind of) a window is required for a boarded up window. It is not obvious. I thought that maybe I could make a boarded up window from scratch on dirt in the middle of nowhere. |
Telling you what the preconditions for the recipes to be available is tricky:
|
I thought about that too now. We should not display multiple entries with the same requirements if only the tile differs, but the tile name is the same. Specifically, if the player cannot distinguish between WINDOW_0 and WINDOW_1 (let's say they have different durability) they should see only one entry for both of these constructions.
I don't have a good solution to the rest, but the vehicle construction menu goes into greater detail that looks too wordy, but when I wouldn't understand something I would look there for answers. Still, if we could solve that one issue, it is still a big improvement. |
The screenshot #73328 (comment) is a great example of repeated things. There is only one difference, the tile required, which is:
So the 1 and 2 should merge into a single entry. The player cannot make any decisions with both entries 1 and 2. They see no difference in the recipes (unless I overlooked something?). Therefore, showing both recipes is only confusing to the player, they have to read more and assume there is some difference they cannot find. That is how I feel when presented with entries 1 and 2. Ideally, it would all show as a single entry with |
I wasn't able to display your image. It links to something that doesn't display for me. Don't know if the "private" part of the link means it won't be visible to others or something else is an issue. |
Sorry, I am just citing the first image in the original post (first message). Edited. |
Describe the bug
Board up window
shows no missing requirements but I cannot build it.There are 4 recipes on the screenshot. The second two require a window, the first two don't mention needing a window.
Attach save file
Game-trimmed.tar.gz
Steps to reproduce
*
board up window
construction recipeENTER
)Expected behavior
Require some sort of window.
Screenshots
Versions and configuration
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
Slowdown Fungal Growth [no_fungal_growth]
]
Additional context
Good first issue. It will just miss something in the JSON.
The text was updated successfully, but these errors were encountered: