[RDY] Adds weapon chemical launcher and new fungicidal gas type as ammo #12765

skYYman · 2015-06-23T18:27:23Z

So here is my first ever contribution to CDDA.

I am a total newbie when it comes to git and I am not really sure where everything goes so far, so please bear with me while I learn.

The idea for this weapon originates from http://smf.cataclysmdda.com/index.php?topic=10630.msg238369#msg238369.

With guidance from Coolthulhu I managed to come up with the below stuff so far.

Coolthulhu · 2015-06-23T18:33:42Z

data/json/recipes/recipe_weapon.json

+  "qualities":[
+    {"id":"SAW_M_FINE","level":1,"amount":1},
+    {"id":"SCREW_FINE","level":1,"amount":1},
+	{"id":"HAMMER","level":2,"amount":1}


Use 4 spaces rather than tabs.

Coolthulhu · 2015-06-23T19:16:45Z

Also, check that "Details" button on the page, right to "Failed". It can be informative.

skYYman · 2015-06-23T19:22:26Z

Indeed, it is.

Jenkins you old scallywag.

Coolthulhu · 2015-06-24T03:58:19Z

src/field.cpp

+                        //check the terrain and replace it accordingly to simulate the fungus dieing off
+                        auto ter = map_tile.get_ter_t();
+                        auto frn = map_tile.get_furn_t();
+                        if(  ) {


if( ter.has_flag( "FUNGAL" ) ) { ter_set( p, t_dirt ); }

Don't bring back fungal trees, dirt mounds etc. Fungalized stuff is pretty much only held together by the fungus, once that died it all falls apart.

Wow, I feel silly. That`s pretty much what I wrote in the very beginning. Where exactly is that flag defined? Feels like I searched everywhere for it.

But thank you.

It isn't really defined anywhere - it doesn't do anything on its own. Check the terrain jsons.

Marrim · 2015-06-24T10:49:26Z

Minor note: perhaps call the ammo type "chemical spray", since it can eventually be expanded to other types, not just fungicide?

skYYman · 2015-06-24T19:42:31Z

Another thing:
I don't understand the 5 deletions that show up in field.cpp
I never touched these lines and in my original file they are not altered either. Is this a bug?

Coolthulhu · 2015-06-24T19:49:09Z

May be just your IDE (codeblocks?). It sometimes cleans up badly ended lines, such as when there's a space before the newline.

Coolthulhu · 2015-06-24T19:50:15Z

src/field.cpp

+                            const auto &ter = map_tile.get_ter_t();
+                            if( ter.has_flag( "FUNGUS" ) ) {
+                                ter_set( p, t_dirt );
+                                furn_set( p, f_null );


You need to have separate check for furniture. Otherwise when a fungal terrain has a non-fungal furniture, it will be destroyed too.

skYYman · 2015-06-24T19:50:36Z

That explains that.

skYYman · 2015-06-25T00:21:16Z

The gas works but I can't figure out how to create it at the pointer, rather than just make it explode out of the character. I don't know how to reference the impact.

Coolthulhu · 2015-06-25T00:30:55Z

Told you in the forum thread: in damage.cpp.

Most of the file is one big function that does exactly that for many different types of ammo.

Rivet-the-Zombie · 2015-06-25T00:49:12Z

src/field.cpp

@@ -2071,6 +2093,23 @@ void map::player_in_field( player &u )
            }
            break;

+        case fd_fungicidal_gas:
+            // Fungicidal gas makes you cough.
+            // Thick fungicidal gas has a chance to poison you.


What if you've crossed a fungal threshold like mycus or marloss? Shouldn't it be doing extra damage/poison to you?

Coolthulhu · 2015-06-25T03:42:44Z

src/damage.cpp

-
+    if( effects.count( "GAS_FUNGICIDAL" ) > 0 ) {
+        for( auto &&pt : g->m.points_in_radius( p, 1, 0 ) ) {
+            g->m.add_field( pt, fd_fungicidal_gas, 4, 0 );


Looks like you're adding a field with density 4. This will be ignored: density is capped at 3 at the moment.

Good to know. I thought this might let the gas linger longer so it simulates the effect of 'sinking in'. Should I revert it to 3?

map::add_field clips the density to 3, so having 4 here won't do anything.

Not sure what you mean by 'sinking in' here. That would probably be achieved better by changing the numbers in field processing, though. spread_gas has arguments like spread chance, outdoor dispersal speedup etc.

I thought there was some kind of counter that reduces field density after a certain amount of time. Figured, if I set it higher the gas remains there longer, thereby simulating the gas 'hanging in the air' after it has been sprayed.
I'll look into spread_gas, that sounds exactly like what I need to modify.

skYYman · 2015-06-25T04:49:31Z

data/json/items/ammo_types.json

+        "type" : "ammunition_type",
+        "id" : "gas_fungicidal",
+        "name" : "fungicidal gas",
+        "default" : "gas_fungicidal"


I was having trouble with assigning a more general chemical_spray ammo-type. I wanted something like this:
{
"type" : "ammunition_type",
"id" : "chemical_spray",
"name" : "sprayable chemical",
"default" : "gas_fungicidal"
}

But it throws a debug-message, saying gas_fungicidal is not a valid ammo.

Sounds like you only changed it in ammo_types, but not in ammo.json: "gas_fungicidal" had the old "ammo_type" field.

"ammo" field refers to the ammo type id. So if you're changing ammo id to "chemical_spray", the fungicidal gas needs "ammo_type": "chemical_spray".

Yeah I did that ;) Still did not work.

Oh forgot: the same in the thrower.

That's it! Also, it makes much more sense, now that I think about it.

skYYman · 2015-06-25T18:56:21Z

Seems like Notepad++ was a little eager and changed all tabstops in the tile_config.json to 4 spaces 😕

Coolthulhu · 2015-06-25T19:05:34Z

src/field.cpp

+                    inhaled = u.add_env_effect("poison", bp_mouth, 5, 30);
+                } else if( cur->getFieldDensity() == 2 ) {
+                    inhaled = u.add_env_effect("smoke", bp_mouth, 2, 7);
+                } else if( u.has_trait("THRESH_MYCUS") || u.has_trait("THRESH_MARLOSS" ) ) {


Both of those else ifs are wrong:

Thick gas will not cause coughing, only poison. In many cases coughing can actually be more dangerous than poison

Mycus mutant will only get the mycus effect if the density == 1

In the mycus block: you don't need to compare density to any of 1, 2 or 3. It can never be lower than 1 or higher than 3

Density 1 should do something too. Maybe just a weak (5 turns?) poison effect?

Mycus mutants will take the damage even when in full hazmat

Coolthulhu · 2015-06-25T19:10:34Z

Balancing:

The spray is incredibly inefficient outdoors. The entire charge of 100 spray disperses in just few turns, covering an area of at most 7x7. You should lower that outdoor spread gas penalty and change that FIRE_100 to something more manageable
Against fungal terrain, even the hazy cloud is 100% efficient in the first turn. It should probably be a random chance dependent on density. Later on it would be nice to actually depend on terrain too, but for now just something like one_in( 10 / density ) would be fine.

Coolthulhu · 2015-06-28T01:41:09Z

src/field.cpp

+                // The gas won't harm you inside a vehicle.
+                bool inhaled = false;
+                // Full body suits protect you from the effects of the gas.
+                if( !u.worn_with_flag("GAS_PROOF") ) {


Invert this if:

if( gas proof ) { break; }

kevingranade · 2015-06-28T05:21:00Z

Working great in a quick test I gave it (annihilating a fungal tower), but I agree with Coolthulu's points.

Coolthulhu · 2015-07-02T03:17:19Z

src/field.cpp

+                    u.hurtall( rng( density, density * 2 ), nullptr );
+                    u.add_msg_if_player( m_bad, _("The %s makes you feel sick."), cur->name().c_str() );
+                }
+            }


You don't do anything with the inhaled variable.

Coolthulhu · 2015-07-02T04:25:46Z

Fixed missing messages on my side.

For the future:

The current spreading looks quite weird: the gas immediately spreads to "hazy cloud", then it sits there for a while and disappears. You don't see thick gas much.
You could nerf it a bit, at least against boss monsters. One "puff" is enough to kill a boss fungus.
At the same time it is still too expensive for large-scale cleaning against fungal terrain.
Hitting anything with a 0 damage projectile produces a message "projectile reflects off x's armor". You could change it so that "JET" flag suppresses it.
It doesn't affect impassable terrain, like fungal trees (the big ones, young ones die just fine) or fungal walls

Chemical Launcher Commits

3780b1a

Coolthulhu reviewed Jun 23, 2015
View reviewed changes

skYYman added 2 commits June 23, 2015 22:28

suggested fixes and first terrain changes

415cbf0

typefixes and balancing, basis for terrain alterations

faebdbc

Coolthulhu reviewed Jun 24, 2015
View reviewed changes

final commits for alpha version

61a0b72

skYYman added 2 commits June 24, 2015 20:39

deleted leftover tabstops, fixed compiler issue, changed ammo type

28c5b0c

more fixes

401c156

skYYman changed the title ~~[WiP] Chemical Launcher~~ Chemical Launcher Jun 24, 2015

skYYman changed the title ~~Chemical Launcher~~ Add weapon chemical launcher and new fungicidal gas type as ammo Jun 24, 2015

Coolthulhu reviewed Jun 24, 2015
View reviewed changes

skYYman changed the title ~~Add weapon chemical launcher and new fungicidal gas type as ammo~~ [WiP] Add weapon chemical launcher and new fungicidal gas type as ammo Jun 24, 2015

ammo type changes reverted, typos corrected

aec4e01

Rivet-the-Zombie reviewed Jun 25, 2015
View reviewed changes

added effects on char with marloss/mycus threshold, added diff furn/ter

09d4f44

Coolthulhu reviewed Jun 25, 2015
View reviewed changes

tweaks, fixes - needs testing for balance now

39770ce

skYYman reviewed Jun 25, 2015
View reviewed changes

BETA - general ammo for launcher

0dfd529

skYYman changed the title ~~[WiP] Add weapon chemical launcher and new fungicidal gas type as ammo~~ Add weapon chemical launcher and new fungicidal gas type as ammo Jun 25, 2015

skYYman closed this Jun 25, 2015

skYYman reopened this Jun 25, 2015

Coolthulhu self-assigned this Jun 25, 2015

added RetroDays tileset support

efbf03a

Coolthulhu reviewed Jun 25, 2015
View reviewed changes

Coolthulhu removed their assignment Jun 25, 2015

skYYman added 2 commits June 25, 2015 23:51

suggested fixes and balancing

c77226d

new flag for gas-proof equipment

cfd851c

Coolthulhu reviewed Jun 28, 2015
View reviewed changes

kevingranade assigned kevingranade and unassigned kevingranade Jun 28, 2015

code cleanup, outdoor age speedup balancing

7324aef

skYYman changed the title ~~Add weapon chemical launcher and new fungicidal gas type as ammo~~ [RDY] Adds weapon chemical launcher and new fungicidal gas type as ammo Jun 29, 2015

Coolthulhu self-assigned this Jul 2, 2015

Coolthulhu reviewed Jul 2, 2015
View reviewed changes

Coolthulhu merged commit 7324aef into CleverRaven:master Jul 2, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RDY] Adds weapon chemical launcher and new fungicidal gas type as ammo #12765

[RDY] Adds weapon chemical launcher and new fungicidal gas type as ammo #12765

skYYman commented Jun 23, 2015

Coolthulhu Jun 23, 2015

Coolthulhu commented Jun 23, 2015

skYYman commented Jun 23, 2015

Coolthulhu Jun 24, 2015

skYYman Jun 24, 2015

Coolthulhu Jun 24, 2015

Marrim commented Jun 24, 2015

skYYman commented Jun 24, 2015

Coolthulhu commented Jun 24, 2015

Coolthulhu Jun 24, 2015

skYYman commented Jun 24, 2015

skYYman commented Jun 25, 2015

Coolthulhu commented Jun 25, 2015

Rivet-the-Zombie Jun 25, 2015

Coolthulhu Jun 25, 2015

skYYman Jun 25, 2015

Coolthulhu Jun 25, 2015

skYYman Jun 25, 2015

skYYman Jun 25, 2015

Coolthulhu Jun 25, 2015

skYYman Jun 25, 2015

Coolthulhu Jun 25, 2015

skYYman Jun 25, 2015

skYYman commented Jun 25, 2015

Coolthulhu Jun 25, 2015

Coolthulhu commented Jun 25, 2015

Coolthulhu Jun 28, 2015

kevingranade commented Jun 28, 2015

Coolthulhu Jul 2, 2015

Coolthulhu commented Jul 2, 2015

[RDY] Adds weapon chemical launcher and new fungicidal gas type as ammo #12765

[RDY] Adds weapon chemical launcher and new fungicidal gas type as ammo #12765

Conversation

skYYman commented Jun 23, 2015

Choose a reason for hiding this comment

Coolthulhu commented Jun 23, 2015

skYYman commented Jun 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Marrim commented Jun 24, 2015

skYYman commented Jun 24, 2015

Coolthulhu commented Jun 24, 2015

Choose a reason for hiding this comment

skYYman commented Jun 24, 2015

skYYman commented Jun 25, 2015

Coolthulhu commented Jun 25, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skYYman commented Jun 25, 2015

Choose a reason for hiding this comment

Coolthulhu commented Jun 25, 2015

Choose a reason for hiding this comment

kevingranade commented Jun 28, 2015

Choose a reason for hiding this comment

Coolthulhu commented Jul 2, 2015