NPC AI + interaction update

[Coolthulhu]

• NPC pathfinding will now avoid traps. It is clairvoyant: NPCs see all non-benign trap. Null trap is now benign, to simplify the code.
• NPC finding a seat on vehicle should work better now. Closes #13468 and allows NPCs to tell apart seats and aisles when selecting a good spot to sit on. Removes the "hop" that NPCs were doing before (a short-ranged teleport that they would do when getting into the vehicle)
• Implemented a NPC menu, similar to zlave menu. Activated by examining a friendly NPC or walking into one. Allows pushing NPCs (more or less like old pushing, except won't make NPCs bash stuff), swapping places with NPCs, examining their wounds (no using healing items, but this makes it way simpler to implement) and attacking. Pushing and swapping is only for friendly NPCs, all can be examined. Good first aid and perception allows seeing exact hp, as Self Aware does for player.
• Big refactoring of "limb menu". Moved from iuse to Character and got rid of a page worth of redundant code (per-limb code was literally ctrl+c+v, 4 times)
• Walking into a zlave will displace it rather than attacking
• Allowed NPCs to push each other out of the way. They don't path around each other yet, but pushing should prevent deadlocks (except when the target NPCs sleeps...)
• Fixed NPC "roaming" (long term goal of acquiring stuff). Due to performance limitations on pathfinding, old deterministic roaming would often result in them getting locked up, trying to wall into a wall of a building. New one will have them stare into the wall for a while, then change direction and get unblocked.

[stk2008]

Wow dude thank you so much :)

I love npc fixes etc :)
On 4 Sep 2015 20:43, "Coolthulhu" notifications@github.com wrote:

• NPC pathfinding will now avoid traps. It is clairvoyant: NPCs see
  all non-benign trap. Null trap is now benign, to simplify the code.
• NPC finding a seat on vehicle should work better now. Closes #13468
  #13468 and allows
  NPCs to tell apart seats and aisles when selecting a good spot to sit on.
  Removes the "hop" that NPCs were doing before (a short-ranged teleport that
  they would do when getting into the vehicle)
• Implemented a NPC menu, similar to zlave menu. Activated by
  examining a friendly NPC or walking into one. Allows pushing NPCs (more or
  less like old pushing, except won't make NPCs bash stuff), swapping places
  with NPCs, examining their wounds (no using healing items, but this makes
  it way simpler to implement) and attacking. Pushing and swapping is only
  for friendly NPCs, all can be examined. Good first aid and perception
  allows seeing exact hp, as Self Aware does for player.
• Big refactoring of "limb menu". Moved from iuse to Character and got
  rid of a page worth of redundant code (per-limb code was literally
  ctrl+c+v, 4 times)
• Walking into a zlave will displace it rather than attacking
• Allowed NPCs to push each other out of the way. They don't path
  around each other yet, but pushing should prevent deadlocks (except when
  the target NPCs sleeps...)
• Fixed NPC "roaming" (long term goal of acquiring stuff). Due to
  performance limitations on pathfinding, old deterministic roaming would
  often result in them getting locked up, trying to wall into a wall of a
  building. New one will have them stare into the wall for a while, then
  change direction and get unblocked.

---

You can view, comment on, or merge this pull request online at:

#13486
Commit Summary

• Bunch of NPC enhancements
• Minor pathfinding bug
• Remove debug stuff
• Add no_bashing parameter to npc moving
• Don't push sleeping NPCs

File Changes

• M data/json/traps.json
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-0
  (3)
• M lua/class_definitions.lua
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-1
  (5)
• M src/character.cpp
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-2
  (182)
• M src/character.h
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-3
  (13)
• M src/game.cpp
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-4
  (138)
• M src/game.h
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-5
  (3)
• M src/iuse.cpp
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-6
  (221)
• M src/npc.h
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-7
  (8)
• M src/npcmove.cpp
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-8
  (277)
• M src/pathfinding.cpp
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-9
  (58)
• M src/vehicle.cpp
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-10
  (11)
• M src/vehicle.h
  https://github.com/CleverRaven/Cataclysm-DDA/pull/13486/files#diff-11
  (1)

Patch Links:

• https://github.com/CleverRaven/Cataclysm-DDA/pull/13486.patch
• https://github.com/CleverRaven/Cataclysm-DDA/pull/13486.diff

—
Reply to this email directly or view it on GitHub
#13486.

[Rivet-the-Zombie]

NPC pathfinding will now avoid traps. It is clairvoyant: NPCs see all non-benign trap.

So no more killing/driving off NPCs using traps? I hope this is a temporary thing.

[Coolthulhu]

Just pathfinding, they still can be murdered by pushing them into traps and it still won't credit the player for the murder with -100 morale.

This was mostly to make them not blunder into open air and pits.

[chaosvolt]

Interesting. If there was a way to make them ignore undiscovered traps without adding to complexity or lag, though...

[kevingranade]

Shouldn't be hard, the method we use with players should scale to NPCs doing the same thing just fine.

[chaosvolt]

Ah. Now if we further made a distinction between "spotted by player" and "spotted by NPC" that would be useful. However, that would add more code to juggle. Simply one list for players and one for NPC would be a step up and not too complex, but giving EVERY NPC their own detection list would get out of hand rapidly.

[kevingranade]

No, it would be just fine to give each NPC a separate list, no problem.

[chaosvolt]

Hmm. I do wonder how many traps, and how many NPCs, it takes to cause problems using that method. X3

[kevingranade]

IIRC they're stored in unordered lists, so it'll be fine until we run out of ram.

[chaosvolt]

Ah right. And compared to map data and other stats, guess it wouldn't be a substantial addition to the amount of data tracked and saved.

[Zireael07]

I <3 this, @Coolthulhu!