Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build_lab, other underground overmap code cleanup #14475

Merged
merged 7 commits into from Jan 4, 2016

Conversation

sparr
Copy link
Member

@sparr sparr commented Dec 18, 2015

This patch consolidates build_ice_lab and build_lab, and then changes the generation algorithm. The new algorithm produces less boxy more "organic" lab shapes. I tweaked the parameters so that the average total size of the lab is still about the same.

One perk of this change is that there will be more choke points in labs, so the lab mapgen could now be updated to put more turrets / traps / strong zombies at the choke points and less in random rooms. This will reduce the "turret guarding nothing, and I can just walk around it" problem that has been lamented on the forum.

also some code cleanup and styling in various places

@sparr
Copy link
Member Author

sparr commented Dec 18, 2015

This gist includes some sample layouts for the old and new generators: https://gist.github.com/sparr/2e6f014d45b5e44c34e7

@DeadLeaves
Copy link
Contributor

While I have no issue with it, wont this make lab challenge really difficult?

@sparr
Copy link
Member Author

sparr commented Dec 18, 2015

@DeadLeaves changing mapgen_lab to put turrets in choke points might make the lab challenge more difficult, but that's not what this PR does. this one just rearranges the overall shape of the lab, without changing anything about what goes in the various rooms.

@kevingranade kevingranade merged commit 901da30 into CleverRaven:master Jan 4, 2016
@sparr sparr deleted the underground_overmap_fixes branch January 10, 2016 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants