New build_lab, other underground overmap code cleanup #14475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch consolidates build_ice_lab and build_lab, and then changes the generation algorithm. The new algorithm produces less boxy more "organic" lab shapes. I tweaked the parameters so that the average total size of the lab is still about the same.
One perk of this change is that there will be more choke points in labs, so the lab mapgen could now be updated to put more turrets / traps / strong zombies at the choke points and less in random rooms. This will reduce the "turret guarding nothing, and I can just walk around it" problem that has been lamented on the forum.
also some code cleanup and styling in various places