Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upNew build_lab, other underground overmap code cleanup #14475
Conversation
sparr
added some commits
Dec 18, 2015
This comment has been minimized.
This comment has been minimized.
|
This gist includes some sample layouts for the old and new generators: https://gist.github.com/sparr/2e6f014d45b5e44c34e7 |
This comment has been minimized.
This comment has been minimized.
|
While I have no issue with it, wont this make lab challenge really difficult? |
This comment has been minimized.
This comment has been minimized.
|
@DeadLeaves changing mapgen_lab to put turrets in choke points might make the lab challenge more difficult, but that's not what this PR does. this one just rearranges the overall shape of the lab, without changing anything about what goes in the various rooms. |
kevingranade
merged commit 901da30
into
CleverRaven:master
Jan 4, 2016
1 check passed
default
Details
sparr
deleted the
sparr:underground_overmap_fixes
branch
Jan 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sparr commentedDec 18, 2015
This patch consolidates build_ice_lab and build_lab, and then changes the generation algorithm. The new algorithm produces less boxy more "organic" lab shapes. I tweaked the parameters so that the average total size of the lab is still about the same.
One perk of this change is that there will be more choke points in labs, so the lab mapgen could now be updated to put more turrets / traps / strong zombies at the choke points and less in random rooms. This will reduce the "turret guarding nothing, and I can just walk around it" problem that has been lamented on the forum.
also some code cleanup and styling in various places