New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for being unable to charge UPS and use UPS-modded tools without UPS #15116
Conversation
@Rivet-the-Zombie, here we go. |
Thank you, @Core0verload! I'll get on this ASAP. |
The game gives no prior warning that you can't remove batteries once you load them into a UPS, so that's going to be a surprise for unwary people. Please include something in the item's description to let them know. Other than that, everything is fine. |
:/ I still can't see the benefit of the change. Originally ups could be
|
A UPS-specific recharging mod would be a good fix for this whole situation; the vanilla UPS wouldn't have to change, and it would give us more options for UPS power. |
This ^ . I've been struggling to articulate exactly what I objected to
|
I might not be following, but is the functionality you want back that the
UPS can create batteries on demand as long as it's charged? If so that is
precisely the thing we wanted to get rid of. The UPS isn't a box you put
batteries in, it's a battery pack itself, so you should be charging and
discharging it, not adding and removing batteries.
|
I think the gist is that folks want three varieties of UPS: One that you load/unload with batteries but can't recharge with a charging station. My suggestion: Did that cover the basics, @Malkeus? |
That is not what I'm asking for at all. The original way it worked was a
|
It's not like unloading UPS is used very often. And everybody was using them with rechargeable mod anyway, so it makes sense to make it rechargeable by default. I don't understand that "we lost control" thing at all. You still have your UPS, you can charge it with batteries without ever touching a recharging station if you want.
Done. |
@rivet yep, that covers it. I often find newer characters have more
|
Who is this everyone you speak of? I agree that unloading is not an issue
|
UPS spawns empty, you can't just loot it for batteries in early game. And using UPS as a power source in the first days isn't very common because you had to find an UPS, some UPS-powered tools and some batteries, with only batteries being common enough for an early survivor to get. |
Rngesus smiles on us from time to time. Not common doesn't feel like a
|
This is UPS's desc. |
That description is vague enough to support any interpretation. Kevin said All I'm really asking for here is some supporting logic for the change. And
|
And I thought the discussion about storage batteries balance was pointless... The only reason behind these changes: people were complaining a lot about UPS being non-rechargeable. I didn't even knew it was possible to make it rechargeable and that a lot of people actually used that. So I made it rechargeable. And what's the supporting logic behind your nitpicking? |
That the whole change was unnecessary precisely because it was already I like the enhancement to the recharging station. I like combining ups and On a personal level, the fact that you call discussion nitpicking, get You changed something to make it capable of doing something it was already
|
So you think that unloading is a major feature of an UPS, and removing it made UPS a lot less capable than it was before, even if it was replaced with an ability to recharge in station. I don't think so. The further discussion will be pointless. |
I think you 'fixed' something that wasn't broken. You can be as dismissive as you like, but it doesn't change the FACT that you didn't know the feature you added already existed. And for the record, I never said it was a major feature, nor that it was a lot less capable, don't put words into my mouth. You still haven't given a reason for the change, btw. |
http://smf.cataclysmdda.com/index.php?topic=12053.msg266096#msg266096 |
If you don't like it, feel free to open a pull that removes ["RECHARGE", "NO_UNLOAD"] from a regular UPS and adds a recipe for converting the regular UPS into a rechargeable. |
So mote it be. |
@@ -4236,7 +4238,7 @@ | |||
"color": "light_green", | |||
"name": "advanced UPS", | |||
"name_plural": "advanced UPS's", | |||
"description": "This is an advanced version of the unified power supply, or UPS. This device has been significantly redesigned to provide better efficiency as well as to consume plutonium fuel cells rather than batteries.", | |||
"description": "This is an advanced version of the unified power supply, or UPS. This device has been significantly redesigned to provide better efficiency as well as to consume plutonium fuel cells rather than batteries. Sadly, it's plutonium reactor can't be charged in UPS charging station.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "its", not "it's".
Fix for being unable to charge UPS and use UPS-modded tools without UPS
Battery-powered UPS is now rechargeable by default. It can be charged in any recharging station, but you can't unload it anymore. The same applies for two items that are supposed to have rechargeable power cells: e-tonfa (it's stated in description) and control laptop (regular laptop has rechargeable cells in it's disassembly). However, you can't charge a plutonium-powered UPS that way.
All UPS-modded tools now could be used without UPS, making UPS mod a complete replacement for rechargeable battery mod, as it was intended.
UPS charging station is added to Humvee's box. Other mil. vehicles already have it.
Fixes #14976.