Double the number of survivor's notes

[kilozombie]

Well, the first batch was written a while ago, and there's tons of new content, references, and quirks to comment on. More variety is always nice. I suppose you should only read the commit if you want spoilers on all of the notes, aha.

Forgive me if the PR is messed up, haven't used git seriously in a while.

[DangerNoodle]

Is this an Arcana mod reference?

[DangerNoodle]

Definitely a Vehicle Additions Pack reference.

Maybe it would be interesting if some mods had relevant snippets for survivor notes. I know that Arcana and Magic Items mod has a snippets section for some other type of note, don't think I've seen more than one show up during play. Seem to only be in the added locations.

[kilozombie]

I could move the mod-related notes to those snippet.json files then, if it'd clean things up a bit.

Actually I'd had multiple ideas for very obviously mod-related notes but refrained because I didn't realize I could add them to those mods, so yeah.

[DangerNoodle]

Might be interesting. Could even pester @chaosvolt to suggest ideas for added quotes, for Arcana mod at least.

[DangerNoodle]

Will be interesting to see.

[chaosvolt]

Hmm. Once upon a time I DID consider adding survivor's notes to More Survival Tools, but I could never think of any good quotes related to the actual content. o3o

Maybe have some arcana ideas though. Just random snippets off the top of my head:

"summoned a blob thing. It ate my car"
"Weather has been awful ever since I raided that mansion."
"HOLY SHIT IT SHOOTS LIGHTNING"
"Funny paper did a thing. Feeling better, but everything is tree now."
"Do not drink from thgolden cup it fucknghhB"
"It's just glass cleaner with random shit in it, why did it turn red?"
"alien dropped more glowy stuff. wonder what happens if I snort it."
"Thought I found a bible in the old church. Found some weird fire cult book instead."
"Robbed by some crazy fucker in a golden cloak. Only thing he wanted was that weird book I got earlier."
"Weak from blood loss. Weapon runs on it. Not enough to bathe the town in hellfire."
"Burned the book of oaths, voices won't stop helpheLL REPENT"

[kilozombie]

Aw shit, you commented that mere moments after I made that commit. Ahah. Some of those are really good.

[chaosvolt]

Doh. Those ideas added to the commit look nice as well, actually. X3

[chaosvolt]

Ah, nice. Seems to better fit the general tone of survivor's notes better, as well.

[kilozombie]

Don't really know why it threw the blazemod one an error... am I just shit at creating new files? It worked ingame when I tested adding it in the mods folder.

[chaosvolt]

Linting apparently is a thing, and it seems to be screwing over a lot of commits.

[kilozombie]

Agh. Well, it's late, I'm gonna head to sleep and leave this for the morning. For now these are all the new notes I've got.

[chaosvolt]

Looks good so far. I would assume ensure that your use of spacing is consistent and such.

No idea whose bright fucking idea it was to make correct code format MANDATORY, when the desired style has changed over time, is not enforced in existing files with even a faint hint of consistency, and when no immediately useful reference is available for people who have no fucking idea what linting is and what the preferred formatting is.

[kilozombie]

I'll go over it once to be consistent, though there's a small spacing inconsistency in the arcana snippets.json which didn't upset anything.

[chaosvolt]

Which might be because the arcana and vanilla snippet files are both pre-existing. Which suggests that not only is this auto-linting thing poorly documented and explained, it also half-asses the task. :V

[kilozombie]

Shrug. I'll go fix the spacing on the other ones for aesthetic's sake and wait for a fix, I guess...?

[chaosvolt]

It would help if the error checker explained what error 65 means. Damn near every other potential problem it can detect will give a rundown on what the problem is.

It's possible that it wants 4 spaces for the lines, instead of...not sure how many snippets.json had to begin with. 8?

EDIT: And removing spaces before the },{ sections might also help.

[kilozombie]

Hrrrk. My mind's melting thinking of all the tiny ways it could be wrong and I don't want to make infinite commits just yet-- that'd be Slightly Unprofessional. aaa

[pisskop]

if were going to put helpful hints onto notes one abour grapplers yanking you off a bike would suffice.

predator impaling, lungers [in base game IWs] lunging, hulks smashing, any thing of this sort

[kilozombie]

Fair point. A streamer died recently in mega-endgame by being instantly killed by a grappler, through three layers of quarterpanels, at 25mph, in power armor. It'd be worth a warning!

[mugling]

It would help if the error checker explained what error 65 means

It also gives you the error message `Linting data/mods/blazemod/snippets.json: ERROR: Unmatched context 'snippet' (see Jenkins output)

I would assume ensure that your use of spacing is consistent and such.

This message is telling you the linter ruleset doesn't yet cover snippet

and when no immediately useful reference is available for people who have no fucking idea what linting is

Extensive documentation is in tools/format/README.md which other authors have already made use of to write new rules. Coverage is improving all the time.

No idea whose bright fucking idea it was to make correct code format MANDATORY

Linting is being activated in stages in a similar manner to astyle. This is controlled by json_whitelist. It is enabled for blazemod from when we merged the new version in #17456.

Merging poor quality JSON then expecting others to maintain it is antisocial. Equally developers breaking mods has also been a problem. The lint tool solves both - you have to commit good JSON and if a developer changes a JSON field elsewhere it will flag your mod as also requiring update.

and what the preferred formatting is.

Try tools/format/example. You can also run tools/cleanup.sh none data/mod/blazemod/snippets.json to automatically reformat that file. This will shortly become a Makefile target similar to make astyle

Which suggests that not only is this auto-linting thing poorly documented and explained, it also half-asses the task

Linting has been extensively discussed on github and other mod authors aren't struggling with it. The fact that the OP and yourself are only recently returned could be a factor here. It might be worth getting up to speed on recent changes and also moderating the tone of your posts. @chaosvolt I'm going to point out the elephant in the room (#15203) and that whilst currently everyone is turning a blind eye to you submitting PR's via third parties this will need to change if your presence becomes disruptive.

[Coolthulhu]

A bit too high level for surv notes

[kilozombie]

Yek, I agree. Replaced it with something of equal humor, hopefully.

[Coolthulhu]

There are no flying mutants and helicopters yet

[kilozombie]

Crashed helis exist, though.

[Coolthulhu]

Sounds like a jab at old dev. I'd rather keep the jabs to current devs.

[kilozombie]

Less of a jab-- just pointing out that he originally made things happen. Tongue-in-cheek, I guess?

[Coolthulhu]

Well, he doesn't exactly like DDA, so probably shouldn't be included.

[kilozombie]

Good point.

[Coolthulhu]

Sounds like mod content. If it is, it should be in a mod.

[kilozombie]

Artifact.

[chaosvolt]

Sorry for getting rather annoyed about this last night, @mugling.

This message is telling you the linter ruleset doesn't yet cover snippet

I can understand the reasoning behind the concept itself, and while this will still trip up new contributors, I acknowledge it's at least possible to make use of it once you're familiar with what it wants and where to get what you need to fix it.

That said, this does indicate that automatic linting is not yet a completely developed feature, and making it cause failed commits due to incompleteness is inexcusable. This is a bigger problem than the minor annoyances I got pissy about earlier.

[kilozombie]

Eh. It's excusable in my book-- I'm just generally confused out of lack of knowledge. This isn't an urgent feature I'm PRing here anyway and some more time to make edits/suggestions isn't minded.

[chaosvolt]

@chaosvolt I'm going to point out the elephant in the room (#15203)

And, I'm sorry? You're dredging up something from over 7 months ago, a pull request in with @kevingranade berated me for failed compiling caused by a bug that was beyond my control, and was additionally unaware of my having successfully compiled a few times before that, when my compiling failures'd been a constant source of frustration even farther back.

I reacted by being a snarky asshole in response to discovering the cause (again, initiated by Kevin's demands that I learn to do something I had already FINALLY figured out), and you should know the rest by now.

In fact, this is relevant in other ways you likely weren't intending. In both cases we have problems caused by something completely unrelated to PR content.

[mugling]

and while this will still trip up new contributors,

Within hours of a new contributor opening a PR you have two of the core developers working on a solution for them? I'd like to think that makes us a welcoming and tolerant community...

than the minor annoyances I got pissy about earlier.

...and posts like yours above are an existential threat to that. You've provided no meaningful assistance and a torrent of abuse. Sat behind a keyboard you have nearly limitless time to reply so there isn't any excuse for such outbursts.

I'm going to point out the elephant in the room (#15203)

Another developer banned you from the project. Their intentions weren't ambiguous. It's been discussed at length by others although I've never personally entered an opinion.

And, I'm sorry? You're dredging up something from over 7 months ag

Would you prefer it was brought up earlier? I'm going to put this back in the box for now so please no expletives, emoji, bumping or off-topic posts. To be clear I'm not changing any previous decision but deciding to act only if otherwise unavoidable.

[DangerNoodle]

I am not sure if any of this is relevant to the current issues regarding this pull request. It seems acceptable for @chaosvolt to make suggestions for snippets, especially since it was my idea to name-drop them for ideas. So long as discussion and implementation of said ideas are kept civil.

I am not fully aware of the "elephant in the room" being brought up, nor why it is relevant to this pull request, other than that being the point when @chaosvolt was removed from the project.

[mugling]

So long as discussion and implementation of said ideas are kept civil.

Always the important part

[kilozombie]

Formatting's all fixed, what's next? Just wait for your PR about linting to go through?

[DangerNoodle]

Regardless, my apologies if requesting their ideas is considered undesirable due to their no longer being allowed to contribute. My reasoning was that they are the most familiar with the Arcana and Magic Items mod, being its author. They also seem to have some sort of background for it that is only visible through a few elements of the content. I do not know whether they have elaborated on those details anywhere.

[mugling]

Formatting's all fixed, what's next? Just wait for your PR about linting to go through?

You need to merge the PR I just made against your branch which adds linter rules for snippet and see if that resolves your problem.

Regardless, my apologies if requesting their ideas is considered undesirable due to their no longer being allowed to contribute

There isn't a need for you to apologize and your contributions are welcome. As above I'm going to defer any action until otherwise unavoidable.

[chaosvolt]

I did preserve some lore on the first page of the forum thread it originated in: http://smf.cataclysmdda.com/index.php?topic=11013.0

Sorry for being so disruptive about this though. As you can probably guess, I can get snarky when it comes to features that appear to cause problems, and failed commits due to someone else's mistake are a personal pet peeve of mine.

I mean hell, that was provoked my assholeish attitude towards Kevin's farming PR that marked the point when our attitudes toward each other started to nosedive, and were ultimately what prompted my outbursts that led to my being barred from the project.

Sorry though. Seems as usual I can't even add feedback without fucking something up.

[mugling]

Sorry though. Seems as usual I can't even add feedback without fucking something up.

We are done here. Further off-topic replies will be moderated.

[mugling]

You need to address @Coolthulhu's review as well before this can be merged

[kilozombie]

I... guess? I forgot to send a comment, but I did adjust the note about 'A MEDICAL' to 'EXTREMELY THIRSTY', it was a good suggestion.

[kilozombie]

Hum-- is that it, then? Your commit is in.

[mugling]

Waiting on a merge from @Coolthulhu on #18349

[kilozombie]

Looks like this one's ready when you are @mugling

[kilozombie]

@mugling ?

[mugling]

Waiting for Jenkins to be restored

[DangerNoodle]

Hopefully the issue with Jenkins will be resolved without issue.