Initialize non-static data after static

[mugling]

As noted by @mutability in #19583 auto pickup and safe mode depend on non-static data so shouldn't be initialized in load_static_data

// Load everything that will not depend on any mods
void game::load_static_data() {
    ....
    // The content they load/initialize is hardcoded into the program.
    // Therefore they can be loaded here.
    // If this changes (if they load data from json), they have to
    // be moved to game::load_mod or game::load_core_data

[mutability]

(from the other issue)

It seems OK to load the global autopickup config [early on] since it's just text and doesn't directly depend on any sort of moddable data, but it doesn't make sense to actually match them up to items (in create_rules()) until the world is loaded.

Delaying the loading of global rules entirely is trickier since you can edit the global rules from the settings menu with no world loaded at all.

[mutability]

A quick workaround would be to bail out of create_rules() immediately if( !g->u ) (or whatever the right test for "actually in a game" is)

[mugling]

Can you PR that. I'm not quite sure what you mean.

[mutability]

Not going to get to it tonight, sorry, I have an early flight in a couple of days and I need to get my sleep schedule back in sync..

[mugling]

No worries, we'll see what the morning brings

[mugling]

Replaced by #19626