Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY]Make ranged cap a soft cap, add hard cap at 60 #20535

Merged
merged 2 commits into from Mar 21, 2017

Conversation

Coolthulhu
Copy link
Contributor

Closes #18299

The current limit - 30 tiles - becomes a soft cap. Aiming at a tile above 30 tile distance adds 3 dispersion to the attack. This can't be mitigated in any way (could be lowered with stats later on, but for now it's just for the uncap).

The resulting effective range (range at which chance to get a good hit is 50+%) goes roughly linearly from ~30 tiles at ~180 dispersion to ~60 tiles at 0 dispersion.

Linear dispersion increase isn't perfect, but it does the job and achieves the intended effect.

Tests are broken for ranges at the cap, but I didn't change anything there. Do gun tests all work in master?

@DangerNoodle
Copy link
Contributor

An improvement at least. I forget what range limit the reality bubble and/or the limit of daytime imposes on it, but I assume that 60 is much closer to the effective limit prior to the cap?

@Coolthulhu
Copy link
Contributor Author

60 is the minimum range from player's spot to edge of bubble. 72 is the maximum such distance.

@DangerNoodle
Copy link
Contributor

Ah, I see. I had suspected that the reality bubble limit was close to that number, but had forgotten the exact details. Thank you for that.

@kevingranade
Copy link
Member

60 is also the maximum sight range, so you could shoot something outside this area with a stray shot, but not target it.

@DangerNoodle
Copy link
Contributor

That should significantly improve the matter then, especially for long-range weaponry and heavy mounted weapons.

@Firestorm01X2
Copy link
Contributor

Firestorm01X2 commented Mar 14, 2017

Maybe it will be good idea to set dispersion per tile to 2 instead 3 to give player chance to hit target even on extreme range?

@Coolthulhu
Copy link
Contributor Author

Nah, 3 is fine.
It still gives almost 50% of a good hit chance at 60 tiles at 0 dispersion.

@Coolthulhu Coolthulhu changed the title [CR]Make ranged cap a soft cap, add hard cap at 60 [RDY]Make ranged cap a soft cap, add hard cap at 60 Mar 18, 2017
@Rivet-the-Zombie Rivet-the-Zombie merged commit e5f5d30 into CleverRaven:master Mar 21, 2017
@DangerNoodle
Copy link
Contributor

Implementation incomplete. See issue: #20708

@Coolthulhu Coolthulhu deleted the range-uncap branch June 15, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants