Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Small town buildings #22052

Merged

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Oct 1, 2017

Added small town buildings from http://smf.cataclysmdda.com/index.php?topic=14434.0.

Thanks to Whaley (http://smf.cataclysmdda.com/index.php?action=profile;u=3470).

Shops

  • bakery (2 variants);
  • candy_shop (2 variants);
  • construction_site (6 variants);
  • icecream_shop;
  • post_office (2 variants).

Overmap specials

  • lumber_yard (4 tiles).

I've decided to move pet_store and zoo to separate PR.

Added small town buildings from http://smf.cataclysmdda.com/index.php?topic=14434.0.

Thanks to Whaley (http://smf.cataclysmdda.com/index.php?action=profile;u=3470).

### Shops

- `bakery` (2 variants);
- `bike_shop`;
- `candy_shop` (2 variants);
- `construction_site` (6 variants);
- `icecream_shop`;
- `pet_store` (2 variants);
- `post_office` (2 variants).

### Overmap specials

- `lumber_yard` (4 tiles);
- `zoo` (9 tiles with 2 variants for 2 tiles).
@ZhilkinSerg ZhilkinSerg changed the title Smalltown buildings pack Small town buildings Oct 1, 2017
@John-Candlebury
Copy link
Member

Animals in the zoo should probably be zombies or dead

@ZhilkinSerg ZhilkinSerg changed the title Small town buildings [RDY] Small town buildings Oct 3, 2017
@ZhilkinSerg ZhilkinSerg changed the title [RDY] Small town buildings [WIP] Small town buildings Oct 5, 2017
@DeadLeaves
Copy link
Contributor

How's this comming along? I'm really looking forward to this PR.

{ "item": "tools_carpentry", "x": 15, "y": 11, "chance": 30 },
{ "item": "power_tools", "x": 9, "y": 12, "chance": 10 },
{ "item": "power_tools", "x": 8, "y": 9, "chance": 10 },
{ "item": "clothing_work_hat", "x": 15, "y": 8, "chance": 0 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 chance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this

{ "item": "2x4", "x": 12, "y": 19 },
{ "item": "2x4", "x": 13, "y": 19 },
{ "item": "2x4", "x": 14, "y": 19 },
{ "item": "2x4", "x": 15, "y": 19 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ton of hard-set planks will look bad. Those should be spawned over an area with rolled x, y and repeat.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this.

{ "monster": "mon_dog_zombie_rot", "x": 2, "y": 9 },
{ "monster": "mon_dog", "x": 2, "y": 13 },
{ "monster": "mon_dog", "x": 2, "y": 15 },
{ "monster": "mon_dog_zombie_rot", "x": 10, "y": 19 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animals should be rolled from a group, not predefined.

{ "item": "dogfood", "x": 15, "y": 12 },
{ "item": "catfood", "x": 16, "y": 12 },
{ "item": "catfood", "x": 17, "y": 12 },
{ "item": "pet_carrier", "x": 8, "y": 14 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The items should be a group, unless there is a good reason to place exact types.

],
"place_monster": [
{ "monster": "mon_bobcat", "x": 8, "y": 5 },
{ "monster": "mon_spider_jumping", "x": 18, "y": 9 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giant jumping spider in normal zoo?

},
"place_monsters": [
{ "monster": "GROUP_FOREST", "x": 15, "y": 19, "chance": 6, "density": 0 },
{ "monster": "GROUP_FOREST", "x": 4, "y": 19, "chance": 6, "density": 0 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Density 0?

"sym": 83,
"color": "i_green",
"see_cost": 5,
"mondensity": 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use copy-from instead of redefining things.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this

@ZhilkinSerg
Copy link
Contributor Author

How's this comming along? I'm really looking forward to this PR.

Slowly 🐢

default

@nornagon
Copy link
Contributor

Ah, it looks like we're both adding a bike shop: #22262. We should merge them into variants :)

@ZhilkinSerg
Copy link
Contributor Author

ZhilkinSerg commented Dec 12, 2017

Ah, it looks like we're both adding a bike shop: #22262. We should merge them into variants :)

I will move bike shop to separate PR. Thanks.

@ZhilkinSerg ZhilkinSerg changed the title [WIP] Small town buildings [RDY] Small town buildings Dec 21, 2017
@kevingranade kevingranade merged commit 4de01c4 into CleverRaven:master Jan 4, 2018
@ZhilkinSerg ZhilkinSerg deleted the mapgen-small-town-buildings-pack branch August 25, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants