Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace chop logs construction with long action #22939
Conversation
boydkr
added some commits
Feb 14, 2018
boydkr
force-pushed the
boydkr:chop-logs-action
branch
to
09e6aa3
Feb 15, 2018
boydkr
reviewed
Feb 15, 2018
| const ter_id ter = g->m.ter( dirp ); | ||
| if( ter == t_trunk ) { | ||
| /** @EFFECT_STR reduces time required to chop down a tree */ | ||
| moves = MINUTES( 70 - p->str_cur ) * 2 / it->get_quality( AXE ) * 100; |
This comment has been minimized.
This comment has been minimized.
boydkr
Feb 15, 2018
•
Author
Contributor
I think this equation (used here and in chop_tree) could use some balance love.
Strength has a tiny effect (1 minute per cut for each strength). Quality has a massive effect. It could also probably use some randomness to simulate different sized trees
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kevingranade
Feb 16, 2018
Member
Maybe move strength to the denominator, something like:
MINUTES( 70 ) / ( ( it->get_quality( AXE ) * 10) + p->str_cur );
boydkr
changed the title
[WIP] Replace chop logs construction with long action
Replace chop logs construction with long action
Feb 15, 2018
This comment has been minimized.
This comment has been minimized.
|
You can also add |
This comment has been minimized.
This comment has been minimized.
|
It reuses the |
This comment has been minimized.
This comment has been minimized.
|
Competes with #22933 |
kevingranade
reviewed
Feb 16, 2018
| void activity_handlers::chop_logs_finish( player_activity *act, player *p ) { | ||
| const tripoint &pos = act->placement; | ||
|
|
||
| g->m.ter_set( pos, t_dirt ); |
This comment has been minimized.
This comment has been minimized.
kevingranade
Feb 16, 2018
•
Member
Not necessary here, but just realized it'd be neat to have a stump item here, might even be useful, it could have the flag for resting a longarm on.
boydkr commentedFeb 14, 2018
Builds on #22730, moving forestry actions to items instead of construction.
Fixes #22931
Time required to chop down a tree depends on tool quality and player's strength: