Replace chop logs construction with long action #22939
Conversation
boydkr
force-pushed
the
chop-logs-action
branch
from
a521f7f
to
09e6aa3
Compare
| const ter_id ter = g->m.ter( dirp ); | ||
| if( ter == t_trunk ) { | ||
| /** @EFFECT_STR reduces time required to chop down a tree */ | ||
| moves = MINUTES( 70 - p->str_cur ) * 2 / it->get_quality( AXE ) * 100; |
There was a problem hiding this comment.
I think this equation (used here and in chop_tree) could use some balance love.
Strength has a tiny effect (1 minute per cut for each strength). Quality has a massive effect. It could also probably use some randomness to simulate different sized trees
There was a problem hiding this comment.
Do you have something exact in mind?
There was a problem hiding this comment.
Maybe move strength to the denominator, something like:
MINUTES( 70 ) / ( ( it->get_quality( AXE ) * 10) + p->str_cur );
boydkr
changed the title
|
You can also add |
|
It reuses the |
|
Competes with #22933 |
| void activity_handlers::chop_logs_finish( player_activity *act, player *p ) { | ||
| const tripoint &pos = act->placement; | ||
|
|
||
| g->m.ter_set( pos, t_dirt ); |
There was a problem hiding this comment.
Not necessary here, but just realized it'd be neat to have a stump item here, might even be useful, it could have the flag for resting a longarm on.
Builds on #22730, moving forestry actions to items instead of construction.
Fixes #22931
Time required to chop down a tree depends on tool quality and player's strength: