Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites #22756 (Firearms Overhaul) as json-only mod #23343

Conversation

fungusakafungus
Copy link
Contributor

using a script from
https://gist.github.com/fungusakafungus/eb2bdf39da73c03dcb2325b3350ff24b#file-gen-mod-from-diff-sh

like this:

git checkout kasanryukin/master
git reset c0e3b6f # fork point

./gen-mod-from-diff.sh PR22756

Not endorsing the actual content of #22756, I have no idea about firearms balancing. Just providing it in a more palatable (easier to use? I hope) form. There's also a zip file here: https://github.com/fungusakafungus/Cataclysm-DDA/releases/tag/PR22756-v1.0

@Firestorm01X2
Copy link
Contributor

Firestorm01X2 commented Apr 1, 2018

As far as I see this: #22756 just changes maximum ranges of guns. It may be usefull but if it is used alone - it just limit current firerarms even more bacause of max ranges limitations.

Nope I was worng - it also changes dispersion of some guns. But it is not much.

@Firestorm01X2
Copy link
Contributor

I mean it will not help with current situation with guns at all.

@fungusakafungus
Copy link
Contributor Author

My idea was that if anyone wants to use that Firearms PR they can just install and turn on the mod and see for themselves if that's their cup of tea or not. There's probably a better place for a mod, feel free to close.

@kevingranade
Copy link
Member

I appreciate your effort, but the PR doesn't actually fix what it sets out to, which is one if the reasons it hasn't been merged.
#22753 discusses what the balance should be, but additionally setting the range on guns doesn't set effective range, just a range cap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants