Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disposable filters for gas masks. #23562

Closed
wants to merge 4 commits into from

Conversation

Vasyan2006
Copy link
Contributor

Add new filter types:

  • Small. Crafted from charcoal and paper. Used in filter mask,
  • Medium. Crafted from charcoal and paper. Used in gas masks, PBA and survivor masks,
  • Heavy. Recipe equal to rebreather cartridge. Used in hazmat and ANBC suits.

All masks provide no enviroment protection by default and must be activated before use, so they will consume filter.
Each filter lasts for 10k turns (5k turns fo hazmat), about 16 ingame hours (8 for hazmat).
This change will remove "put-on-and-forget" flag from gas masks and they will require more attention, but without excess grinding.

Linting has changed all lines, should I keep it this way or just add new stuff with old formatting?

@SilearFlare
Copy link

good change

@ZhilkinSerg ZhilkinSerg added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Apr 21, 2018
@John-Candlebury
Copy link
Member

Why not activate/disable them automatically when needed, or making them consume charges only when being used to filter fields?

Less keypress from the player is good, one of the most common complains about the game is the obtuse ui based in lots of keybindings

@Vasyan2006
Copy link
Contributor Author

Automatic charges consuming in hazard environment will be the best solution, but my skill_computer is not enough for this coding.

@Night-Pryanik
Copy link
Contributor

Those linting changes are unrelated, making the PR huge and therefore hard to review. I recommend you drop this PR and open a new one with only addition of disposable filters.

@Vasyan2006
Copy link
Contributor Author

Reopen #23580 without linting, please close this PR.

@smolbird
Copy link
Contributor

The page has an option to close your own PRs.

@Vasyan2006 Vasyan2006 deleted the carnival-masks branch June 27, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants