Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tiles build regression #23760

Merged
merged 1 commit into from
May 19, 2018
Merged

Fix Tiles build regression #23760

merged 1 commit into from
May 19, 2018

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented May 18, 2018 •
edited

Visual Studio 2017All tiles builds started to fail recently (apparently after merging of #23161).

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments OS: Windows Issues related to Windows operating system labels May 18, 2018
@ZhilkinSerg ZhilkinSerg changed the title Fix build regression in Visual Studio 2017 Fix Tiles build regression May 18, 2018
@ZhilkinSerg ZhilkinSerg added OS: macOS Issues related to macOS / OSX operating system OS: Linux Issues related to Linux operating system (P2 - High) High priority (for ex. important bugfixes) labels May 18, 2018
@vschule vschule mentioned this pull request May 19, 2018
Closed
@ZhilkinSerg ZhilkinSerg added the <Bugfix> This is a fix for a bug (or closes open issue) label May 19, 2018
@ZhilkinSerg
Copy link
Contributor Author

Self merging as it is is rather urgent.

@ZhilkinSerg ZhilkinSerg merged commit 42fb6fd into CleverRaven:master May 19, 2018
@ZhilkinSerg ZhilkinSerg deleted the fix-regression-vs2017 branch May 26, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Code: Build Issues regarding different builds and build environments OS: Linux Issues related to Linux operating system OS: macOS Issues related to macOS / OSX operating system OS: Windows Issues related to Windows operating system (P2 - High) High priority (for ex. important bugfixes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ZhilkinSerg