New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leadworks guns rework #24187
Leadworks guns rework #24187
Conversation
Leadworks rifles rework
Pistols and shotgun
formatting json
formatting more
data/json/items/gunmod/barrel.json
Outdated
"description": "A Leadworks built in heavy duty barrel especially designed for prolonged shooting. Reduce accuracy but increase damage output and weapon range.", | ||
"price": 0, | ||
"damage_modifier": 3, | ||
"dispersion_modifier": 60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the rationale for these numbers? How does it increase muzzle velocity and effective range while reducing accuracy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is debuff for LMG. Originally L523-LMG has +60 relative dispersion. Now it comes from that mod in addtion to damage and range bonus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact it should be 90 because gyro stybilizer reduce dispersion to 30.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+90 is even worse. Increasing muzzle velocity and effective range while decreasing accuracy has no grounding in reality. If the weapon's stats were originally way out they need fixing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'll just put this +60 back to weapon stats. This barrel will just increase range and damage.
fromatting
Leadwork heavy duty barrel sipersion to 90
data/json/items/gun/223.json
Outdated
"range": -6 | ||
} | ||
"built_in_mods": [ "lead_red_dot_sight", "lead_barrel_small", "lead_laser_sight", "lead_stabilizer" ], | ||
"valid_mod_locations": [ [ "accessories", 2 ], [ "sights", 1 ], [ "barrel", 1 ], [ "underbarrel", 1 ], [ "rail", 1 ] ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab.
data/json/items/gun/223.json
Outdated
@@ -107,7 +107,7 @@ | |||
"name": "L2037 Backup", | |||
"name_plural": "L2037 Backups", | |||
"//": "Most real-life autorevolvers use 6-7.5 inch barrel, but this one's mentioned to be particularly massive.", | |||
"description": "Developed by Leadworks as a companion sidearm to the L523 modular system, this massive autorevolver fires the powerful .223 round, but suffers high recoil as a result. It has a weighted barrel to make recoil more manageable and a 5-chamber cylinder.", | |||
"description": "Developed by Leadworks as a companion sidearm to the L523 modular system, this massive autorevolver fires the powerful .223 round, but suffers high recoil as a result. It has a weighted barrel to make recoil more manageable and a 5-chamber cylinder. Holographics and laser sights built in for additonal accuracy. Similar to other Leadworks products it doesn't accept third-party modifications.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a convention that there should be two spaces after periods.
data/json/items/gun/223.json
Outdated
}, | ||
{ | ||
"id": "l_lmg_223", | ||
"copy-from": "l_base_223", | ||
"type": "GUN", | ||
"name": "L523-LMG", | ||
"description": "Leadworks LLC's bullpup L523 platform utilizes the ubiquitous 5.56 round in multiple applications, and is designed to part-swap quickly, safely, and effectively from one to the next. The rather ambitious light machine gun variant incorporates a heavy-duty barrel & foregrip as well as the Leadworks gyro system. Unlike the other configurations, the L523 LMG can be loaded with ammo belts.", | ||
"description": "Leadworks LLC's bullpup L523 platform utilizes the ubiquitous 5.56 round in multiple applications, and is designed to part-swap quickly, safely, and effectively from one to the next. The rather ambitious light machine gun variant incorporates ACOG scope, a heavy-duty barrel, foregrip, bipods and as well as the Leadworks gyro system. Unlike the other configurations, the L523 LMG can be loaded with ammo belts.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bipod, not bipods.
data/json/items/gunmod/barrel.json
Outdated
"copy-from": "barrel_big", | ||
"type": "GUNMOD", | ||
"name": "Leadworks barrel extension", | ||
"description": "A Leadworks built in longer barrel increases the muzzle velocity of a firearm, contributing to both accuracy and damage slows aiming.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...but slows aiming"?
data/json/items/gunmod/barrel.json
Outdated
"copy-from": "barrel_big", | ||
"type": "GUNMOD", | ||
"name": "Leadworks heavy duty barrel", | ||
"description": "A Leadworks built in heavy duty barrel especially designed for prolonged shooting. Reduce accuracy but increase damage output and weapon range.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two spaces after period.
data/json/items/gunmod/sights.json
Outdated
"copy-from": "lead_acog_scope", | ||
"type": "GUNMOD", | ||
"name": "Leadworks ACOG and red dot combo scope", | ||
"description": "An Leadworks built in (proprietary) combination optic & red-dot sights for quick and accurate targeting.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... combination of optic ..."?
"copy-from": "bipod", | ||
"type": "GUNMOD", | ||
"name": "Leadworks bipod", | ||
"description": "Leadworks built in bipods designed to provide a forward rest and reduce motion. Although they greatly improve handling of recoil they are usable only on certain surfaces and are slow to equip.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bipod, not bipods. Also, singular, so "it", not "they".
Formating and spelling
Integrated bayonet for leadworks carbine
removed comma
…rel dispersion move LMG dispersion from barrel to contruction and removing short barrel dispersion
nerfed leadworks big barrel. It increases range already.
lead_barrel_big rande to +4
Added additional weight to leadworks rifles
range of leadworks big barrel to +3
lw long barrel dispersion to -50
range_modifier instead of range
Added attachments to extra leadworks revolvers
removed dot in bayonet name
reail laser sight dispersion to 30. To avoid separate PR for that change
Leadwoks retractable bayonet dispersion to 0
description of L2032 Lookout
Description
Note that I write "Added" I mean that it was not in the despription. Before none of Leadworks gun contains any attahments. |
New attachments weight to zero
formatting and weight
bayonet desc
All right. I've got it. Ok. Then ready. |
small tweak
final tweak
Currently bayonets are not capable to doing reach attack at all. Not new one only. Mentioned issue year old. |
I need to think about carbine. Who the hell in the right mind will integrate bayonet in weapon hull in 21 centuary? I'll replace bayonet with something else. |
underslung shotgun to carbine and shortening names
Removed date
L1820 Long Ranger is Leadworks gun. Added built in holo
Changed descriptions
Long ranger description
I've added built in underslung shotgun to L523-CAR carbine. It suits it better than 20x century pointy thing. Leadworks baynonet was removed completely. Also I've missed L1820 Long Ranger rifle. Now it comes with holo sight and laser sight. And yes - no extra attachments. I understand that it kinda spoils original Wild West feel but it is not original Winchester- it is modern reimagining. So why not add some modern attachments to it since Leadworks likes attachments (especially now)? |
added laser sight to L1820 Long Ranger
Description change
Ready. |
Replaced hybrid scope for rifle with 2 separate scopes
Replaced combo scope (hybrid acog+red dot) on L523-MBR rifle with 2 separate sight: acog and red-dot. Game can handle multiple scopes properly (or it should be by code). Let it do it. Separate entity for combo scope not worth it and was removed. |
Removed ZOOM from lead_red_dot_sight. It was mistake
I hope it is finally done. |
Don't miss this please:
It can be easily reverted for civilian guns, however. I want to make Leadworks "modular" manufacturer who pack his guns with attachments but do not allow to modify his guns and has hard warranty rules. Leadworks milspec guns are mostly modular (L523 platform) but their modules also contains attachments that also can't be removed. If solder critically break some attachment - he can just replace whole module. The only proper way to remove Leadworks attachments is using complex factory machnines and tools so lit very unlikely for player to be able to do it in current situation. However Leadworks guns designed to allow field repair and maintenance. To certain degree of course. |
Currently Leadworks guns mention that they have a lot of built in attachments. But in fact they contains none of that. Leadwork weapon stats pretend to reflect atthments effect. But in most cases missed effects from attachments.
For example L523-DSR rifle has bipods by its description but in fact it does not contains it so L523-DSR does not get stabilization bonus intended for bipods.
L523-MBR rifle in fact does not contain scope that mention in its description so it does not get reduced sight dispersion. And so on.
This PR going to change that.
Now all Leadworks guns have special irremovable proprietary(!) Leadworks attachments.
Added a lot of irremovable proprietary(!) Leadworks attachments. Scopes, sights, barrels, gyro stabilization system , e.t.c
Most of them releated on existing ones with certain modification of stats.
So now all Leadworks gun actually will be Christmas Tree Guns and will have all necessary effect of attachments.
Changed some exisitng guns to make them more like Leadworks guns.
For example L2037 Backup now come with built-in Holo sight and laser sight and does not accept addtitonal attachments.
List of changes
Idea
I want to make Leadworks "modular" manufacturer who pack his guns with attachments but do not allow custom modifications his guns and has hard warranty rules. But this way user get everything he (probably) need right of the box.
Not all Leadworks guns are modular but rules "No third party attachments" and "No custom modifications" are strict.
Leadworks milspec guns are mostly modular (L523 platform) but their modules also contains attachments that also can't be removed. If solder critically break some attachment - he can just replace whole module.
The only proper way to remove Leadworks attachments is using complex factory machnines and tools so it is very unlikely for player to be able to do it in current apocalyptic situation.
However Leadworks guns designed to allow field repair and maintenance. To certain degree of course.
It sounds like bad idead at first, but getting gun, packed with everything you need "right of the box" is actually nice.
IRL there is XM29_OICW https://ru.wikipedia.org/wiki/XM29_OICW .
As far as know It didn't succeed commercially. And didn't succeed at all.
Minor changes
Rules
New attachments
L523 modular system (Leadworks milspec rifles)
Rifles
Shotguns
Pistols