Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Simple Camp Bugs #24427

Merged
merged 5 commits into from Jul 23, 2018

Conversation

Projects
None yet
4 participants
@acidia
Copy link
Contributor

commented Jul 22, 2018

Two very simple fixes:
#24424, Opened cans before distributing them around the litter area
#24426, Stopped companions from returning charge 0 seeds to the player after planting

acidia added some commits Jul 22, 2018

@acidia

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2018

Quick explanation, fixes #24425. Item overflow was turned off because when I went through it originally I thought the items would spill out of their stacks as the sorting method was trying to stack them, causing an infinite loop. Just turned overflow on and tested to verify, spilling out occurs later so we're safe with how it works. If some logs are missing when you hit shift+V to get a count, look inside the hard building and crates. With 1200 logs, I was able to account for all of them after sorting but they do spill into every empty tile around your sort point.

@acidia

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2018

OK, no more changes. Last one was just moving "Reset Sort Points" to be immediately available. A couple of people forgot where they set their food distribution point at and where facing restarting the camp (not that they had gotten far).

@AMurkin

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2018

Please write "Fixes #24424, Fixes #24426" to autoclose issues.

@cainiaowu

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2018

@acidia, there are still a lot of lines not translated in the query_yn in src/npstalk.cpp and some most mission definition in src/mission_companion.cpp .

Will you fix that too?

@ZhilkinSerg ZhilkinSerg merged commit d659bd4 into CleverRaven:master Jul 23, 2018

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 22.764%
Details
gorgon-ghprb Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.