Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tree stumps (forest's table) #24885

Merged
merged 3 commits into from Aug 17, 2018
Merged

Add tree stumps (forest's table) #24885

merged 3 commits into from Aug 17, 2018

Conversation

nexusmrsep
Copy link
Contributor

@nexusmrsep nexusmrsep commented Aug 16, 2018

Reference: #24878

Credits for the idea goes to @EirenexTheDragon

This PR adds tree stumps.
Tree stumps are a leftover of cutting down tree. They can be cut further, but the yields are not satisfying as from cutting a log. Yet you might still get some usable wood.

What's more important is that it serves as an equivalent to other flat furniture needed for butchering like table, counter, washing machine, dryer, pool table, coffin, and leather tarp.

TODO: stumps should appear by themselves in map generator, as trees fall down with age, leaving stumps behind, and active pre-cataclysm forest cultivation could leave some behind.

@boydkr
Copy link
Contributor

boydkr commented Aug 16, 2018

I would question the whole idea of your average stump being a "flat surface". That would only happen if you use a chainsaw to cut down a tree, and if the tree is multiple feet in diameter.

An 8" diameter tree trunk isn't going to be much of a table after you chop it down with a stone axe.

@FantasticFwoosh
Copy link

FantasticFwoosh commented Aug 16, 2018

Please correct me if there is any mis-information, but tree stump objects already appear in the experimental build to substitute entire masses of cut down-trees (spawning multiple tree stumps in the path of where the tree is fell) which are then broken down into log objects etcetera with a axe.

Would you be putting in any more work to improve & expand on this inconsistency in line with your design vision to make it a bit more realistic if not a little more comprehensive?

  • Removing a single stumps from the ground with a shovel for instance.

@EirenexTheDragon
Copy link
Contributor

the tree that is cut appears in Chesthole as tree stump, which is wrong, but it allows to use that texture for an actual tree stump.

@boydkr
Copy link
Contributor

boydkr commented Aug 16, 2018

Those objects are technically tree trunks (t_trunk), and this PR adds a stump (t_stump).

You're right, though, the in game sprites for t_trunk look like a stump

@Mecares
Copy link
Contributor

Mecares commented Aug 17, 2018

Could you give boulders the ability to be used as flat surface for butchering?

@sfsworms
Copy link

Boulders aren't really flat though. At this point, it'd be better to consider if the flat surface requirement is really needed (why not simply on the ground?) or maybe allow ground butchery, but gives a bonus to yield if a flat surface is available (less meat getting dirty in the process. )

@ZhilkinSerg ZhilkinSerg self-assigned this Aug 17, 2018
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required changes:

image

@ZhilkinSerg ZhilkinSerg removed their assignment Aug 17, 2018
@nexusmrsep
Copy link
Contributor Author

@boydkr this might be in fact valid, but until we sort out the feedback for butchery and finally decide the road to go, this is a valid option, and besides, tree stumps were not there, so it'd be nice to have them anyway.

@ZhilkinSerg ZhilkinSerg merged commit cb0c80d into CleverRaven:master Aug 17, 2018
@nexusmrsep nexusmrsep deleted the tree_trunks branch August 17, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants