Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging vehicles #2520

Merged
merged 13 commits into from Aug 22, 2013
Merged

Dragging vehicles #2520

merged 13 commits into from Aug 22, 2013

Conversation

kevingranade
Copy link
Member

There are some refinements that can still happen, mostly having the pushed/pulled vehicle lead or trail the player so you don't end up losing your grip on vehicles that can rotate, and so that things behave the way you expect.
I think this is in a useful state though, we can worry about the leading/following behavior later.

@CataJenkins
Copy link

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/432/

@HeIsMohawk
Copy link

Is there any way to extend this to include hitching vehicles to one another? that way you could have your RV for long-distance travel and drag your favorite bike along for city exploration.

@kevingranade
Copy link
Member Author

Extend this no, basically the same kind of thing would need to be implemented separately for vehicles, there might be some common code, but probably not.

Also some notes for refinements I want to make:
Ditch the encumbrance thing, it makes less sense the more I think about it. Letting go and re-grabbing something is basically going to be a non-action, so imposing penalties other than move speed just forces the player to ungrab/act/grab when they want to do something else.
Add a move penalty when pushing or dragging based on vehicle weight vs player str and possibly other factors.
Add a weight check in plmove to account for changing conditions, e.g. lowered strength preventing player from being able to budge vehicle.

@CataJenkins
Copy link

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/451/

@kevingranade
Copy link
Member Author

I forgot to add a default keybinding, so that needs to happen, possibly add something you can push around to the tutorial as well.

@i2amroy
Copy link
Contributor

i2amroy commented Aug 20, 2013

Definitely fun to play around with. One little thing (in addition to default keybindings) is that if you run a shopping cart over a trap then it doesn't trigger. This can lead to a strange situation where you can run your cart over a landmine and then be fine until you step there yourself.

As for the keybinding I suggest rebinding "G" to this. Center view can then be moved to ':', which can be taken from the view map command since it still has 'm'.

@CataJenkins
Copy link

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/486/

@kevingranade
Copy link
Member Author

"Vehicle drag code" commit, and had to adjust the caster and shopping carts to make it work.I rolled trap detection in to the

i2amroy added a commit that referenced this pull request Aug 22, 2013
@i2amroy i2amroy merged commit 4040395 into CleverRaven:master Aug 22, 2013
@kevingranade kevingranade deleted the dragging-vehicles branch April 26, 2014 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants