Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npctalk: add support for NPC backstories #26738

Merged

Conversation

2 participants
@mlangsdorf
Copy link
Contributor

commented Nov 17, 2018

Summary

SUMMARY: Features "npctalk: add support for NPC backstories"

Purpose of change

Erk is working on additional NPC dialogue to provide backstories, but that will require NPCs to generate dynamic lines based on their class and traits. Player responses will also depend on the NPC's traits and class.

Add dynamic line and response filters for NPC traits, NPC class, and player character effects.

Includes test cases and documentation updates.

Describe the solution

This is just an expansion of existing dynamic line and response functionality.

npctalk: add support for NPC backstories
Add dynamic line and response filters for NPC traits, NPC class,
and player character effects.

Includes test cases and documetation updates.

@mlangsdorf mlangsdorf added this to In progress in NPC dialog overhaul via automation Nov 17, 2018

@ZhilkinSerg ZhilkinSerg self-assigned this Nov 18, 2018

@ZhilkinSerg ZhilkinSerg merged commit 1af0a24 into CleverRaven:master Nov 18, 2018

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on npctalk_backstory_support at 25.847%
Details
gorgon-ghprb Build finished.
Details

NPC dialog overhaul automation moved this from In progress to Done Nov 18, 2018

@ZhilkinSerg ZhilkinSerg removed their assignment Nov 18, 2018

@mlangsdorf mlangsdorf deleted the mlangsdorf:npctalk_backstory_support branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.