Adds junk barrier -> junk wall #27036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
<Enhancement / Feature>
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/developing-a-fortified-evac-shelter-structure/17837/15 |
Construction was quite out of date so I linted the whole thing to earn Travis- CI's trust.
It's just too big of a mess.
May as well complete the set
Commas, mistaken item name, forgot to edit move cost of floor
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
data/json/construction.json
Outdated
| "required_skills": [ [ "fabrication", 4 ] ], | ||
| "time": 90, | ||
| "qualities": [ [ { "id": "SAW_M", "level": 1 } ], [ { "id": "GLARE", "level": 2 } ] ], | ||
| "tools": [ [ [ "oxy_torch", 4 ], [ "welder", 20 ], [ "welder_crude", 30 ], [ "toolset", 30 ] ] ], |
There was a problem hiding this comment.
You can replace this with welding_standard requirement.
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Adds shanty-town walls comprised of bolted-together junk"Purpose of change
The majority of makeshift construction in game currently uses wood, be it logs or two by fours. Although scrap wood is abundant in the cataclysm, so is scrap metal. Current metal walls (even though they're termed as "scrap metal walls" in the source file) are very sturdy, welded together walls made from durable steel plates, with very high HP. Where are the junky walls made from rusty corrugated sheet metal and bits of old cars held together by zip ties and loose bolts?
Describe the solution
The recipe for these walls allows a wide range of possible ingredients, to help them be true 'scrap walls' made from what is on hand. The recipe doesn't require a welder, but to help make up for this, does require a realistic wide range of other tools - in particular a wrench and a drill, to put holes where needed and shove bolts (represented by spikes), nails (representing metal screws which don't exist in game), or wires through. The HP of these walls is enough to make them decent barriers against zombies, but not nearly as high as the higher tier walls. It is also not quite as tough as log palisades, although it fills a similar role.
The first stage construction, junk metal barrier, can be reinforced with significantly more resources (still welder-free) to build a junk metal wall. This wall is comparable in durability to brick, and less durable than log or stone. A decent wall, but nothing game-breaking I think. The barrier, like the palisade wall, does not support a roof. The upgrade does.
Describe alternatives you've considered
I considered requiring a few welding charges for the reinforcement phase (4 acetylene, 20 regular, 30 makeshift/integrated) but decided that it defeated the purpose of the whole affair.
I'd consider an alternate reinforcement phase that used a welder and required fewer materials to make though. In fact I may include that before the PR is done. (Edit: talked myself into it and added)
Additional context
I intend to add a few more parts to this before the day is done - junk metal roofs and gates mainly. Probably not in this PR.