Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds junk barrier -> junk wall #27036

Merged
merged 13 commits into from Dec 20, 2018

Conversation

Projects
None yet
5 participants
@I-am-Erk
Copy link
Contributor

commented Dec 10, 2018

Summary

SUMMARY: Content "Adds shanty-town walls comprised of bolted-together junk"

Purpose of change

The majority of makeshift construction in game currently uses wood, be it logs or two by fours. Although scrap wood is abundant in the cataclysm, so is scrap metal. Current metal walls (even though they're termed as "scrap metal walls" in the source file) are very sturdy, welded together walls made from durable steel plates, with very high HP. Where are the junky walls made from rusty corrugated sheet metal and bits of old cars held together by zip ties and loose bolts?

Describe the solution

The recipe for these walls allows a wide range of possible ingredients, to help them be true 'scrap walls' made from what is on hand. The recipe doesn't require a welder, but to help make up for this, does require a realistic wide range of other tools - in particular a wrench and a drill, to put holes where needed and shove bolts (represented by spikes), nails (representing metal screws which don't exist in game), or wires through. The HP of these walls is enough to make them decent barriers against zombies, but not nearly as high as the higher tier walls. It is also not quite as tough as log palisades, although it fills a similar role.

The first stage construction, junk metal barrier, can be reinforced with significantly more resources (still welder-free) to build a junk metal wall. This wall is comparable in durability to brick, and less durable than log or stone. A decent wall, but nothing game-breaking I think. The barrier, like the palisade wall, does not support a roof. The upgrade does.

Describe alternatives you've considered

I considered requiring a few welding charges for the reinforcement phase (4 acetylene, 20 regular, 30 makeshift/integrated) but decided that it defeated the purpose of the whole affair.

I'd consider an alternate reinforcement phase that used a welder and required fewer materials to make though. In fact I may include that before the PR is done. (Edit: talked myself into it and added)

Additional context

I intend to add a few more parts to this before the day is done - junk metal roofs and gates mainly. Probably not in this PR.

I-am-Erk added some commits Dec 10, 2018

@kevingranade

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/developing-a-fortified-evac-shelter-structure/17837/15

I-am-Erk added some commits Dec 10, 2018

Lint terrain and construction files
Construction was quite out of date so I linted the whole thing to earn Travis- CI's trust.
Unlint construction.json
It's just too big of a mess.
Add junk floors
May as well complete the set
Fix minor errors
Commas, mistaken item name, forgot to edit move cost of floor
Show resolved Hide resolved data/json/terrain.json Outdated
Show resolved Hide resolved data/json/terrain.json Outdated
Show resolved Hide resolved data/json/terrain.json Outdated
Apply suggestions from code review
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
"required_skills": [ [ "fabrication", 4 ] ],
"time": 90,
"qualities": [ [ { "id": "SAW_M", "level": 1 } ], [ { "id": "GLARE", "level": 2 } ] ],
"tools": [ [ [ "oxy_torch", 4 ], [ "welder", 20 ], [ "welder_crude", 30 ], [ "toolset", 30 ] ] ],

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Dec 14, 2018

Member

You can replace this with welding_standard requirement.

Show resolved Hide resolved data/json/terrain.json Outdated
Show resolved Hide resolved data/json/terrain.json Outdated
Show resolved Hide resolved data/json/terrain.json Outdated

Night-Pryanik and others added some commits Dec 19, 2018

Update data/json/terrain.json
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Update data/json/terrain.json
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Update data/json/terrain.json
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

@kevingranade kevingranade merged commit e22a85b into CleverRaven:master Dec 20, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details

@I-am-Erk I-am-Erk deleted the I-am-Erk:ScrapWalls branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.