New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemistry Tools 2: Add basic analytical science tools #27212

Merged
merged 15 commits into from Jan 6, 2019

Conversation

Projects
None yet
3 participants
@I-am-Erk
Copy link
Contributor

I-am-Erk commented Dec 21, 2018

Summary

SUMMARY: Infrastructure "Adds not-quite implemented basic analytical tools for chemistry."

Purpose of change

Using new chemistry qualities (#27206), adds the sub-tools that collectively form a "basic analytical kit" with analysis quality 1.

Describe the solution

After some discussion I think the most important analytical tools for common chemical synthesis are:

  • accurate weighing
  • spectrophotometry
  • pH measurement
  • melting point determination
  • thin layer chromatography

I have created sub-tools to represent these tools, and a "kit" tool that includes all of them and has an analysis 1 quality.

Describe alternatives you've considered

Each of these items could have analysis 1 individually, but that winds up with weird things like using a melting point apparatus to determine if your ethanol is pure. Instead, if a recipe only needs a melting point apparatus, you could always include that in the recipe or something.

Additional context

Part of an ongoing effort to add science tools, without putting them all in a single huge PR.

Next up will be recipes to construct and disassemble these tools. Or maybe item groups to get these tools into the game. I don't know yet.

Night-Pryanik and others added some commits Dec 21, 2018

Update data/json/items/tools.json
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Add science tools to their own file
Place science.json in the items/tools folder to reduce the burden of reading a single large json
Plurals
The plural of apparatus is complicated.
commas
Holy smokes, item groups is a giant mess
fix a brain fart
Mixed cuvettes and burettes up. It's been a while since I did labwork.
Add glass prisms and light detectors
These are for crafting the spectrophotometer.
Revert item groups for now.
The linting is annoying me.

@ZhilkinSerg ZhilkinSerg self-assigned this Dec 28, 2018

@ZhilkinSerg ZhilkinSerg removed their assignment Dec 28, 2018

Update data/json/items/tool/science.json
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>

@ZhilkinSerg ZhilkinSerg merged commit 0e45533 into CleverRaven:master Jan 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gorgon-ghprb Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment