Multiple Sidebar Panel Layouts #28152

KorGgenT · 2019-02-10T00:30:20Z

Summary

SUMMARY: Interface "Multiple Sidebar Panel Layouts"

Purpose of change

Closes #27367
Makes the sidebar much more customizable.

Describe the solution

Uses @nsklaus 's idea of the rearrange-able panel system in the sidebar, and expands that to have the ability to have multiple layouts.

Describe alternatives you've considered

Additional context

"Classic":

"Compact":

"Labels": (panel in screenshot is the window that allows panel selection)

Currently does not save settings when you close the game.
Will want some input from translators.

compass?
Center panel admin.
Pixel minimap

OrenAudeles · 2019-02-10T00:41:35Z

Does this work in Curses builds or is it Tiles only?

KorGgenT · 2019-02-10T00:42:24Z

still need to try curses, this definitely works in tiles

Amneiger · 2019-02-10T02:12:08Z

I said this on Reddit already, but I'm very happy to see a player-customizable UI.

My C++ is too substandard to figure this out: which option is the default that's used when loading the game?

The screenshot for the classic vehicle sidebar is the same as the screenshot for the compact vehicle sidebar. For everyone's peace of mind, could you take a moment to get that fixed?

KorGgenT · 2019-02-10T02:12:44Z

I said this on Reddit already, but I'm very happy to see a player-customizable UI.

My C++ is too substandard to figure this out: which option is the default that's used when loading the game?

The screenshot for the classic vehicle sidebar is the same as the screenshot for the compact vehicle sidebar. For everyone's peace of mind, could you take a moment to get that fixed?

"classic" is default when loading the game

Amneiger · 2019-02-11T03:41:49Z

"classic" is default when loading the game

Got it, thanks.

It looks like you changed the screenshots? The current classic vehicle screenshot doesn't match what I see in a pre-UI changes build:

I use Safe mode in vehicles to help me notice nearby mi-gos and crash sites when driving in new places, or to see when I'm getting too close to an uncleared town, so the absence of it stood out to me. I also noticed the lack of temperature, because I like to know when it's okay to plant seeds or immediately notice if I've stepped into an ice lab, and then I just don't bother putting the thermometer down.

KorGgenT · 2019-02-11T03:48:24Z

"classic" is default when loading the game

Got it, thanks.

It looks like you changed the screenshots? The current classic vehicle screenshot doesn't match what I see in a pre-UI changes build:

I use Safe mode in vehicles to help me notice nearby mi-gos and crash sites when driving in new places, or to see when I'm getting too close to an uncleared town, so the absence of it stood out to me. I also noticed the lack of temperature, because I like to know when it's okay to plant seeds or immediately notice if I've stepped into an ice lab, and then I just don't bother putting the thermometer down.

I see. That's a pretty easy fix. I sort of moved the fuel gauge because i thought it would be better to have more information (i.e. your stats) while driving, and having safe mode on is pretty much irrelevant, though i guess i can put it back to be totally the old style. also the temp does show, i just only had a thermometer on me in the third screenshot (in the lab)

I will also say that once the ability to save the settings is put in (no promises it will be this PR) the default will be made into "labels" since labels make it a bit easier for new players.

Amneiger · 2019-02-12T14:17:26Z

i guess i can put it back to be totally the old style

Folks are a bit twitchy about this at the moment. I'm going to suggest that classic be as close to the original UI as much as possible.

I will also say that once the ability to save the settings is put in (no promises it will be this PR) the default will be made into "labels" since labels make it a bit easier for new players.

That's fair, since people will be able to save their settings and not have to use the other UIs if they don't want to.

KorGgenT · 2019-02-13T02:59:24Z

I have made edits until I can't see any more edits to make. For those of you following this PR and do not know how to compile, and also run windows, I have made a distributable for you to check out.

AMurkin · 2019-02-15T19:11:46Z

Manage zones and List all items around have display issues.

AMurkin · 2019-02-15T19:26:20Z

Also Sidebar position (Right/Left) option does nothing now. And game.h have unused bool right_sidebar;

KorGgenT · 2019-02-16T03:02:30Z

@AMurkin I fixed the sidebar position thing, would you elaborate on the display issues you are referring to?

AMurkin · 2019-02-16T10:13:53Z

Manage zones

No zones around:

Now	PR

If there is a zone defined, inner part of the zones manager is momentarily displayed and erased.

List all items around

Now	PR

AMurkin · 2019-02-17T09:19:34Z

When I scroll items in List all items around window sometimes it didn't draw target marker to item's position. Also if sidebar position is set to Left, it hides sometimes.

Zones doesn't highlighted now. In the master version their tiles are blinking.
No border here at the bottom-right:

I-am-Erk · 2019-02-19T04:02:55Z

Does this solve #14748?

KorGgenT · 2019-02-19T04:31:06Z

not by itself

Co-Authored-By: KorGgenT <curtis.r.merrill@gmail.com>

This reverts commit 49b97f6.

This reverts commit e1fd512.

Co-Authored-By: KorGgenT <curtis.r.merrill@gmail.com>

src/mission_companion.cpp

rumly111 · 2019-03-19T06:17:52Z

I get segfault when I try to turn on the pixel minimap

ghost · 2019-03-19T08:02:04Z

still need to try curses, this definitely works in tiles

yea, get back with that before clearing to merge, oh wait..

KorGgenT · 2019-03-19T12:27:19Z

still need to try curses, this definitely works in tiles

yea, get back with that before clearing to merge, oh wait..

sorry. we spoke about it on discord at the time. it worked.

kevingranade · 2019-03-19T17:47:22Z

src/game.cpp

+    minimapY = 0;
+    pixelminimapW = MINIMAP_WIDTH;
+    pixelminimapH = ( pixelminimapW / 2 );
+    if( pixel_minimap_custom_height &&


kevingranade · 2019-03-19T17:49:10Z

src/panels.cpp

+int window_panel::get_height() const
+{
+    if( height == -1 ) {
+        return get_option<int>( "PIXEL_MINIMAP_HEIGHT" );


ghost · 2019-03-19T18:12:42Z

This will cause problems with editmap()
I've fixed one crash from faction camps callign editmap.
There will likely be others ( int in discord has found one )
Probably with debug map editing and anything that uses editmap.
width = TERMX - TERRAIN_WINDOW_TERM_WIDTH; in editmap() will be zero now, it seems, when before it wasnt.
and a zero width will cause problems.

paulenka-aleh · 2019-03-22T19:17:13Z

@KorGgenT

How do I enter sidebar options menu?

Sorry for a dumb question, just downloaded latest experimental, copied previous settings and after playing for 5 minutes realized minimap is too way small for me and some menus float to the left (e.g. pickup) while I used to focus on the right side while paying the game. I tried googling, checking help, checking keybindings, going through options but didn't manage to find a way. I didn't dived into the code yet though...

Edit: okay, I guess "Toggle Panel Admin" isn't something I could guess... I would really rename it to, say "Customize sidebar" / "Sidebar options" / "Configure sidebar" / "Sidebar config" or anything alike. It's already called "sidebar" in options so one is likely to look for it rather than "panel". "Admin" isn't something I thought of either, don't think anything in game is called so... And it's not actually "toggle" too, the key just brings up the customization menu and labels, but it won't hide it back.

KorGgenT force-pushed the ui branch from 7797648 to acc470f Compare February 10, 2019 00:57

KorGgenT force-pushed the ui branch 2 times, most recently from 41294cd to ef79398 Compare February 10, 2019 04:45

ZhilkinSerg added <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` 0.D Freeze labels Feb 10, 2019

kevingranade mentioned this pull request Feb 11, 2019

Toggle compass #27891

Closed

KorGgenT force-pushed the ui branch 2 times, most recently from a6dc4aa to 8d08461 Compare February 12, 2019 01:27

KorGgenT changed the title ~~[WIP] Multiple Sidebar Panel Layouts~~ Multiple Sidebar Panel Layouts Feb 13, 2019

kevingranade added this to Candidate Features in 0.E Release Feb 18, 2019

ifreund mentioned this pull request Feb 19, 2019

[WIP] UI code and appearance update #27862

Closed

KorGgenT force-pushed the ui branch from 2f76efa to 9fa9add Compare February 21, 2019 14:20

KorGgenT and others added 14 commits March 18, 2019 16:51

remove commented code

b81b4e4

center view on list_items_and_monsters

7264b51

removed commented code

a9f788f

fixed edge target list window option

a8b6800

pixel minimap height option

1f384a9

Update src/game.cpp

1091a16

Co-Authored-By: KorGgenT <curtis.r.merrill@gmail.com>

Revert "pixel minimap height option"

07040e3

This reverts commit 49b97f6.

pixel minimap height option

e2d2323

add character to force window to render

44f38f1

Revert "add character to force window to render"

c094cab

This reverts commit e1fd512.

Update iexamine.cpp

9cf898b

change wind display to new code

7c3d947

Co-Authored-By: KorGgenT <curtis.r.merrill@gmail.com>

clamp panel height to window height

8f213e8

panels aren't drawn if they go off screen

dd173cc

KorGgenT force-pushed the ui branch from 43ae738 to dd173cc Compare March 18, 2019 20:51

kevingranade reviewed Mar 19, 2019

View reviewed changes

src/mission_companion.cpp Outdated Show resolved Hide resolved

KorGgenT added 2 commits March 18, 2019 22:36

Update mission_companion.cpp

17ebef8

remove dead variables

9e4f6ac

kevingranade merged commit 353ca4b into CleverRaven:master Mar 19, 2019

0.E Release automation moved this from Non-vote Candidate (Maintainer's Choice) to Done Mar 19, 2019

KorGgenT deleted the ui branch March 19, 2019 03:32

ghost mentioned this pull request Mar 19, 2019

[WIP]Wind affects sound attenuation #28805

Closed

kevingranade reviewed Mar 19, 2019

View reviewed changes

ghost mentioned this pull request Mar 19, 2019

Fixed crash when starting a new camp and disappearing camp #28821

Merged

ZhilkinSerg mentioned this pull request Aug 2, 2019

Mouse provides no tooltip #32839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple Sidebar Panel Layouts #28152

Multiple Sidebar Panel Layouts #28152

KorGgenT commented Feb 10, 2019 •

edited

OrenAudeles commented Feb 10, 2019

KorGgenT commented Feb 10, 2019

Amneiger commented Feb 10, 2019

KorGgenT commented Feb 10, 2019 •

edited

Amneiger commented Feb 11, 2019

KorGgenT commented Feb 11, 2019

Amneiger commented Feb 12, 2019

KorGgenT commented Feb 13, 2019

AMurkin commented Feb 15, 2019

AMurkin commented Feb 15, 2019

KorGgenT commented Feb 16, 2019

AMurkin commented Feb 16, 2019

AMurkin commented Feb 17, 2019

I-am-Erk commented Feb 19, 2019 •

edited

KorGgenT commented Feb 19, 2019

rumly111 commented Mar 19, 2019

ghost commented Mar 19, 2019

KorGgenT commented Mar 19, 2019

kevingranade Mar 19, 2019

kevingranade Mar 19, 2019

ghost commented Mar 19, 2019

paulenka-aleh commented Mar 22, 2019 •

edited

Multiple Sidebar Panel Layouts #28152

Multiple Sidebar Panel Layouts #28152

Conversation

KorGgenT commented Feb 10, 2019 • edited

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Additional context

OrenAudeles commented Feb 10, 2019

KorGgenT commented Feb 10, 2019

Amneiger commented Feb 10, 2019

KorGgenT commented Feb 10, 2019 • edited

Amneiger commented Feb 11, 2019

KorGgenT commented Feb 11, 2019

Amneiger commented Feb 12, 2019

KorGgenT commented Feb 13, 2019

AMurkin commented Feb 15, 2019

AMurkin commented Feb 15, 2019

KorGgenT commented Feb 16, 2019

AMurkin commented Feb 16, 2019

Manage zones

List all items around

AMurkin commented Feb 17, 2019

I-am-Erk commented Feb 19, 2019 • edited

KorGgenT commented Feb 19, 2019

rumly111 commented Mar 19, 2019

ghost commented Mar 19, 2019

KorGgenT commented Mar 19, 2019

kevingranade Mar 19, 2019

Choose a reason for hiding this comment

kevingranade Mar 19, 2019

Choose a reason for hiding this comment

ghost commented Mar 19, 2019

paulenka-aleh commented Mar 22, 2019 • edited

KorGgenT commented Feb 10, 2019 •

edited

KorGgenT commented Feb 10, 2019 •

edited

I-am-Erk commented Feb 19, 2019 •

edited

paulenka-aleh commented Mar 22, 2019 •

edited