Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed carnivore requirement from saprovore #28176

Closed
wants to merge 1 commit into from
Closed

Removed carnivore requirement from saprovore #28176

wants to merge 1 commit into from

Conversation

sneeze-attack
Copy link
Contributor

Summary

SUMMARY: Balance "Removed carnivore requirement from saprovore"

Purpose of change

Closes #27488

Describe the solution

Removed carnivore requirement from saprovore mutation

Describe alternatives you've considered

Cancel carnivore when reaching rat post-thresh. I figured this wouldn't be desired as no other mutations cancel out traits specifically when reaching post threshold.

Additional context

None

@paulenka-aleh
Copy link

Bear threshold does cancel carnivore unless I'm terribly wrong.

@sneeze-attack sneeze-attack changed the title Removed carnivore requirement from saprovore [CR] Removed carnivore requirement from saprovore Feb 12, 2019
@sneeze-attack
Copy link
Contributor Author

@paulenka-aleh you are correct, thanks!

I am ok with this change or implementing it as a cancel when reaching rat post-thresh, whichever makes the most sense.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Bugfix> This is a fix for a bug (or closes open issue) labels Feb 12, 2019
@sneeze-attack sneeze-attack changed the title [CR] Removed carnivore requirement from saprovore Removed carnivore requirement from saprovore Feb 12, 2019
@sneeze-attack
Copy link
Contributor Author

Changed title back. Saprovores consume decaying organic material, not necessarily meat only.

@kevingranade
Copy link
Member

Merged onto 0.D and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants