Apply negative stat modifiers in player::suffer #28240
Conversation
The player::suffer function applies stat modifiers for a few effects but does not update the current stat variables. This causes the modifiers to not be used by anything. fixes CleverRaven#18147
|
I think this fixes the negative stat modifiers from addictions as well. |
| str_cur = get_str(); | ||
| int_cur = get_int(); | ||
| dex_cur = get_dex(); | ||
| per_cur = get_per(); |
There was a problem hiding this comment.
This "fix afterwards" approach doesn't seem quite right. Furthermore, this chunk was copied from player::process_artifact() verbatim.
I'd suggest updating stats inside corresponding bonus setters: set_str_bonus() updates str_cur, set_int_bonus() updates int_cur, and so on. This would be more robust, enable better encapsulation, and some code deduplication as a bonus.
There was a problem hiding this comment.
I agree that that would be a much better way to do it. I was trying for the minimal code impact here that would fix the bug. I'll make another PR that has more code changes and the maintainers can choose which fix they'd prefer.
Actually the whole str_cur variable is the non-encaspulated version, Character::get_str() is the correct function to call. It just seems like the refactoring to move away from str_cur is incomplete.
There was a problem hiding this comment.
#28282 I've solved the bug a different way, only one of these PRs needs to be applied.
ifreund
added
[C++]
|
Obsoleted by #28282 |
Summary
SUMMARY: Bugfixes "Applies stat penalties from power overload and solar sensitivity"
Purpose of change
The player::suffer function applies stat modifiers for a few effects but does not update the current stat variables. This causes the modifiers to not be used by anything.
Fixes #18147 - Power overload str penalty not showing up
Describe the solution
Updates the current stat variables after applying all suffer effects.
Describe alternatives you've considered
Considered only updating the stat variables after applying any individual stat change, but that would be a lot of code duplication.
Additional context
This save includes a character with the Power Overload bionic and the solar sensitivity line of mutations. Loading the save and waiting one turn before and after this fix should clearly demonstrate the fix on the stat panel.
TestTown.zip