Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistory apartment towers #29057

Merged
merged 14 commits into from Mar 31, 2019
Merged

Multistory apartment towers #29057

merged 14 commits into from Mar 31, 2019

Conversation

LovamKicsiGazsii
Copy link
Contributor

@LovamKicsiGazsii LovamKicsiGazsii commented Mar 27, 2019

Summary

SUMMARY: Content "Added new z levels to apartments"

Purpose of change

Apartments were named apartment towers, but they only had 1 floor.

Describe the solution

Added new storeys, new furniture and terrains, nested chunks.
Apartment_con_new has 6+1 floors.
Apartment_mod_new has 5+1 floors.

Describe alternatives you've considered

Renaming it apartments, but this was a better solution.

Screenshots

apt_con_new_1
apt_con_new2
tech_roof

apt_mod_new_3
apt_mod_new_2
apt_mod_new_1

@curstwist
Copy link
Contributor

Could add televison spawns. Livingroom look a little empty.

@LovamKicsiGazsii
Copy link
Contributor Author

I'll add televisions, standing lamps and trash cans.

@Mecares
Copy link
Contributor

Mecares commented Mar 28, 2019

You might want to spawn a small technical room for the elevator tech on the roof it needs to be one level above the top most floor an elevator reaches.

@mlangsdorf mlangsdorf added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Mar 28, 2019
@LovamKicsiGazsii
Copy link
Contributor Author

Added new furnitures to the living rooms, updated the screenshots. I haven't done a techinal room for the elevator (yet). I don't know what to use for that (maybe a broken generator/ heavy machinery and a computer?).

@Mecares
Copy link
Contributor

Mecares commented Mar 29, 2019

Sounds good to me, in general some roofs would be nice places for rooftop gardening, but I'm not sure how the game would react to dirt as a roof.

@LovamKicsiGazsii
Copy link
Contributor Author

LovamKicsiGazsii commented Mar 29, 2019

That's a good idea. It could be a new nested chunk. I don't think it would cause an issue, we already have gardens in labs.

Also, I'll need to lint the palette.

@LovamKicsiGazsii
Copy link
Contributor Author

LovamKicsiGazsii commented Mar 29, 2019

How about this:
tech_room
Another update to screenshots.

@ZhilkinSerg ZhilkinSerg self-assigned this Mar 31, 2019
@ZhilkinSerg ZhilkinSerg merged commit 5225ecb into CleverRaven:master Mar 31, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Mar 31, 2019
@LovamKicsiGazsii LovamKicsiGazsii deleted the patch-17 branch December 30, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants