Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trait "Deaf" #29124

Merged
merged 8 commits into from Apr 1, 2019

Conversation

Projects
None yet
8 participants
@SantosValourion
Copy link
Contributor

commented Mar 29, 2019

Summary

SUMMARY: Content "Adds new Trait 'Deaf'"

Purpose of change

Adds the trait Deaf into the game, which makes it impossible to hear things.

Describe the solution

Trait gives a '0' on your hearing modifier which should make it impossible to hear things.

Describe alternatives you've considered

Not adding the Trait.

Additional context

N/A

Added Trait Deaf
Adds the trait Deaf, making it impossible to hear.
@DoctorGoat

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

I'd like to suggest a (fairly) easy to install cochlear CBM.

SantosValourion added some commits Mar 29, 2019

@SantosValourion SantosValourion changed the title Add Trait "Deaf" Add Trait "Deaf" [WIP] Mar 29, 2019

Bad Hearing Changes into Deaf
Bad Hearing Changes into Deaf.
@Ilysen

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

I think there's an is_deaf() check somewhere in the C++ code, so you could add this to it if you've used C++ before.

Add Effect is_deaf
If Player has trait deaf, is_deaf is true.
@SantosValourion

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

I think there's an is_deaf() check somewhere in the C++ code, so you could add this to it if you've used C++ before.

I think I got it, thanks for the heads up there.

Show resolved Hide resolved data/json/mutations.json Outdated
@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

Nice trait for RP purposes (I'll definitely pick it up), and I support the idea of a cochlear CBM (we already have those IRL ;) )

@SantosValourion

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2019

Nice trait for RP purposes (I'll definitely pick it up), and I support the idea of a cochlear CBM (we already have those IRL ;) )

Haha that would be cool, still pretty new to this and haven't touched CBM's yet. Maybe ill get there one day.

@SantosValourion SantosValourion changed the title Add Trait "Deaf" [WIP] Add Trait "Deaf" Mar 31, 2019

Show resolved Hide resolved data/json/mutations.json Outdated
You're not your.
Grammer Error Fixed.

@ZhilkinSerg ZhilkinSerg merged commit 1bad38c into CleverRaven:master Apr 1, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
gorgon-ghprb Build finished.
Details

@SantosValourion SantosValourion deleted the SantosValourion:AddDeaf branch Apr 1, 2019

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/latest-experimental-features/5582/1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.