Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trait "Deaf" #29124

Merged
merged 8 commits into from Apr 1, 2019
Merged

Add Trait "Deaf" #29124

merged 8 commits into from Apr 1, 2019

Conversation

SantosValourion
Copy link
Contributor

Summary

SUMMARY: Content "Adds new Trait 'Deaf'"

Purpose of change

Adds the trait Deaf into the game, which makes it impossible to hear things.

Describe the solution

Trait gives a '0' on your hearing modifier which should make it impossible to hear things.

Describe alternatives you've considered

Not adding the Trait.

Additional context

N/A

Adds the trait Deaf, making it impossible to hear.
@DoctorGoat
Copy link
Contributor

I'd like to suggest a (fairly) easy to install cochlear CBM.

@SantosValourion SantosValourion changed the title Add Trait "Deaf" Add Trait "Deaf" [WIP] Mar 29, 2019
Bad Hearing Changes into Deaf.
@Ilysen
Copy link
Contributor

Ilysen commented Mar 29, 2019

I think there's an is_deaf() check somewhere in the C++ code, so you could add this to it if you've used C++ before.

If Player has trait deaf, is_deaf is true.
@mlangsdorf mlangsdorf added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics labels Mar 29, 2019
@SantosValourion
Copy link
Contributor Author

SantosValourion commented Mar 29, 2019

I think there's an is_deaf() check somewhere in the C++ code, so you could add this to it if you've used C++ before.

I think I got it, thanks for the heads up there.

@Zireael07
Copy link
Contributor

Nice trait for RP purposes (I'll definitely pick it up), and I support the idea of a cochlear CBM (we already have those IRL ;) )

@SantosValourion
Copy link
Contributor Author

Nice trait for RP purposes (I'll definitely pick it up), and I support the idea of a cochlear CBM (we already have those IRL ;) )

Haha that would be cool, still pretty new to this and haven't touched CBM's yet. Maybe ill get there one day.

@SantosValourion SantosValourion changed the title Add Trait "Deaf" [WIP] Add Trait "Deaf" Mar 31, 2019
Grammer Error Fixed.
@ZhilkinSerg ZhilkinSerg merged commit 1bad38c into CleverRaven:master Apr 1, 2019
@SantosValourion SantosValourion deleted the AddDeaf branch April 1, 2019 17:27
@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/latest-experimental-features/5582/1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants