Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add results for deconstructing/bashing subway/railroad terrain #29628

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

jokermatt999
Copy link
Contributor

@jokermatt999 jokermatt999 commented Apr 16, 2019

Summary

SUMMARY: Bugfixes "Add results for deconstructing/bashing subway/railroad terrain"

Purpose of change

Previously, these terrains couldn't be deconstructed or bashed

Describe the solution

Added relevant "bash" and "deconstruct" fields

Describe alternatives you've considered

Have ties return 2x4s instead of a possible log, but that seemed less realistic than a hunk of wood and some splinters

Additional context

Hmm, I bet some NPCs could set up base with those materials...

@kevingranade
Copy link
Member

Needs styling.

@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Apr 16, 2019
@jokermatt999
Copy link
Contributor Author

I ran it through the web linter, does that work? I haven't figured out astyle yet; still figuring out setup for a dev environment.

@ifreund
Copy link
Contributor

ifreund commented Apr 16, 2019

I ran it through the web linter, does that work? I haven't figured out astyle yet; still figuring out setup for a dev environment.

Yeah the web linter is fine for json. Astyle is for the c++ code.

@AMurkin
Copy link
Contributor

AMurkin commented Apr 17, 2019

Proper summary category would be: Bugfixes.

@ZhilkinSerg ZhilkinSerg merged commit f689218 into CleverRaven:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants