Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting 'awl pike' to finally be called 'pike'. #30591

Merged
merged 7 commits into from
May 18, 2019

Conversation

JonahDes
Copy link
Contributor

@JonahDes JonahDes commented May 18, 2019

SUMMARY: Content "Changes item names and descriptions of the awl pike."

Summary

Renames mentions of the awl pike and its derivatives into the pike, which is what the weapon is. The awl pike may effectively 'disappear' from the game as a result, simply being renamed.

Purpose of change

Simply hopes to remove confusion about the awl pike given cursory inspection.

Describe the solution

Edits tools.json and melee.json mentions of the awl pike. More may exist, and will be edited if found.

JonahDes added 4 commits May 18, 2019 00:56
For a long time now, the awl pike has been considered the longer variant of the standard pike, with the REACH3 Flag; this has been an issue addressed by Kevin before, but the actual ID of the items hasn't been adjusted since then.

The change just renames the awl pike to the pike.

There may be changes to other files in the future involving the other pike.
Fits with other name changes, following the reasoning that the awl pike is in fact, just a pike.
Updated inferior and fake 'awl pikes' to 'pike'.
Updated pike entry in tools.json for awl pike.
@NotFuji
Copy link
Contributor

NotFuji commented May 18, 2019

The description still needs to be fixed. Actual awl-pikes do have spike heads, but regular pikes use the more traditional bladed spearheads.

It might be more justified to keep the awl-pike as it is, but give it a shorter attack range, and add a separate regular pike item.

@JonahDes
Copy link
Contributor Author

The description still needs to be fixed. Actual awl-pikes do have spike heads, but regular pikes use the more traditional bladed spearheads.

It might be more justified to keep the awl-pike as it is, but give it a shorter attack range, and add a separate regular pike item.

The item was referred to as a pike by Kevin in the past, it was just never made into the actual pike. Another weapon, with a shorter reach, also existed. It may also still exist and could take the name of the awl pike.

The reason for the shift of names was that the awl pike is about 2-3 Feet shorter and yet had longer reach variables than the pike did.

@Rivet-the-Zombie Rivet-the-Zombie merged commit c8d9863 into CleverRaven:master May 18, 2019
@Aloxaf Aloxaf mentioned this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants