Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quieter nurse #30616

Merged
merged 4 commits into from
May 19, 2019
Merged

Quieter nurse #30616

merged 4 commits into from
May 19, 2019

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented May 18, 2019

Summary

SUMMARY: Bugfixes "Makes nurses less chatty"

Purpose of change

fixes #30608

Describe the solution

Drop proba to add flavor messages to 1%
Change check_up special attack to happen every 20mn instead of 30s
Add a 2% chance to turn hostile again after detecting cbm

The spam was caused by the defective nurse bot iniating its attack but being unable to finish it due to being friendly and thus not able to grab.

Describe alternatives you've considered

Copy pasting code from complain_about to make it work for monsters but it was a bit too complicated for me.

Making the defective nurse bot able to attack while being Friendly

Additional context

This reduces the spam but staying near the bot for a prolonged period of time will probably still fill your log.
This also make it quite difficult to subdue the defective nurse bot if you have CBMs

@Fris0uman Fris0uman changed the title Quieter nurse [WIP] Quieter nurse May 18, 2019
@Fris0uman Fris0uman changed the title [WIP] Quieter nurse Quieter nurse May 18, 2019
@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Info / User Interface Game - player communication, menus, etc. labels May 18, 2019
@kevingranade kevingranade merged commit 2082efe into CleverRaven:master May 19, 2019
@Fris0uman Fris0uman deleted the quiet_nurse branch June 29, 2019 17:38
@Fris0uman Fris0uman mentioned this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Friendly nurse bots play excessive amounts of messages
3 participants