Document constructions and remove time constant #30731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1275,7 +1275,7 @@ void load_construction( JsonObject &jo ) | |||
| con.category = jo.get_string( "category", "OTHER" ); | |||
| // constructions use different time units in json, this makes it compatible | |||
| // with recipes/requirements, TODO: should be changed in json | |||
| con.time = jo.get_int( "time" ) * 1000; | |||
| con.time = to_moves<int>( time_duration::from_minutes( jo.get_int( "time" ) ) ); | |||
There was a problem hiding this comment.
Eventually this should just be a duration, but that's out-of-scope for what you're doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Remove constant factor from construction time and document constructions"Purpose of change
Standardizing units as a prelude to cutting turn time.
Describe the solution
Constructions times were already defined as minutes so I left that as is. I removed the time constant from the minute to move conversion so it will switch properly with turn time.