move plmove, ramp_move, autoattack to namespace #30794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Move game::plmove(), game::ramp_move() and game::autoattack() to avatar_action namespace"
Purpose of change
There's a whoe bunch of functions that don't really live in the right place: these are examples of functions that don't really need to be owned by game.
I chose the name
avatar_action
because there are a bunch of other functions in game that could also go here, and all of these things have an effect on the player, but may not necessarily want to be owned by avatar either.Describe alternatives you've considered
putting these functions into the avatar class. i i decided against it because there's a lot of stuff that will go into that class in time anyway, and keeping it to a reasonable size would be a reasonable course of action while it's still in the process of being refactored.
Additional context
I needed to move a couple of things from private to public in game, though some of those will be moved out of game anyway eventually.