[WIP] Flamethrower guitar #31788
[WIP] Flamethrower guitar #31788
Conversation
Modified item and recipe files to add craftable electric guitars with built in amplifiers, and then flamethrower guitars with those amplified guitars. Neither of these are intended to spawn as loot nor be up for sale by NPCs.
Made some corrections after testing, also attempted to implement the "musical_instrument" use_action to the flamethrower guitar. Continuous playing does not seem to work, may need to be revised.
data/json/items/tool_armor.json
Outdated
| { | ||
| "type": "TOOL_ARMOR", | ||
| "id": "guitar_amplifier", | ||
| "name": "amplifier electric guitar", |
There was a problem hiding this comment.
| "name": "amplifier electric guitar", | |
| "name": "electric guitar amplifier", |
There was a problem hiding this comment.
Yeah, my naming of that item was too ambiguous. In order to not get the item confused with an actual guitar amplifier, I renamed it to "amplified electric guitar".
|
How are you meant to learn the recipe for the guitar amplifier? There's no |
ZhilkinSerg
added
[JSON]
|
Please also add this to the no flaming weapons items blacklist. |
Renamed `guitar_amplifier`/`amplifier electric guitar` to "amplified" instead, as that's less ambiguous about what the item is. Added autolearn to recipe for amplified guitar. Added `flamethrower_guitar` to the flaming weapons blacklist.
Changed the `flamethrower_guitar` from gun type to wearable tool type, then embedded gun info. copy-from doesn't seem to work as expected in the embedded gun info object. Right now, everything seems to be working as expected (including the music playing), but the ammo count for the loaded magazine is not decreasing, and the flamethrower has an ear-ringing report when fired. The lack of ammo consumption makes this totally broken, so if I can't manage a fix I'll have to revert, work on the reverted GUN version, or cancel the PR entirely if nothing works out.
| "use_action": { | ||
| "type": "musical_instrument", | ||
| "speed_penalty": 15, | ||
| "volume": 40, |
There was a problem hiding this comment.
| "volume": 40, | |
| "volume": "10 L", |
| "name": "flamethrower guitar", | ||
| "description": "A simple, home-made flamethrower strapped onto an electric guitar with a built-in amp. This impractical device of musical mayhem is likely to lead to a pyrotechnics mishap for someone.", | ||
| "weight": 3907, | ||
| "volume": 50, |
There was a problem hiding this comment.
| "volume": 50, | |
| "volume": "12500 ml", |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
|
Please ping me to reopen this PR when you are ready to continue where you have left. |
Summary
SUMMARY: Content "Adds a flamethrower electric guitar."
Purpose of change
I liked the suggestion by /u/KoboldCommando in the reddit changelog thread.
Describe the solution
Edits to json files to create the flamethrower_guitar gun and its recipes. As part of this, introduced a craftable
guitar_amplifieritem which is an electric guitar with a jury-rigged, tiny amp built in to it. It's much louder than the base electric guitar.Describe alternatives you've considered
Not wanting to ride eternal, shiny and chrome.
Additional context
guitar_amplifier. I'm able to play for one turn in testing, but it doesn't continuously play like the other musical instruments. Is this just something that can't be neatly implemented into a gun item without c++ edits? Or is it best to change the flamethrower guitar to a tool item and try to embed the gun info? A more seasoned contributor may be able to save me a lot of time with some guidance. Otherwise, I'll try some more attempts, leave as-is (you can kind of play it), or just remove the musical instrument action.