Update winded #31911
Update winded #31911
Conversation
|
Why close? |
|
I missed something important to actually fix the bugs, so i closed it while i went to find it |
ZhilkinSerg
added
<Bugfix>
|
I agree with this change. Winded effect should represent strain and limit activity that player may partake after burning all the stamina. It's an exclamation mark and a warning not to strain yourself any longer rather then a one shot penalty for crossing the line. |
|
one shot kill from winded was a bug. |
| @@ -4627,7 +4627,7 @@ void player::update_stamina( int turns ) | |||
| float stamina_recovery = 0.0f; | |||
| // Recover some stamina every turn. | |||
| // Mutated stamina works even when winded | |||
| float stamina_multiplier = ( !has_effect( effect_winded ) ? 1.0f : 0.0f ) + | |||
| float stamina_multiplier = ( !has_effect( effect_winded ) ? 1.0f : 0.1f ) + | |||
There was a problem hiding this comment.
This has a side effect of opening the player up to losing stamina when winded and encumbered, i.e.
stamina_multiplier - 0.1
base regen = 20
mouth encumbrance = 30
on line 4634, stamina_recovery += 0.1 * 20 - 3
stamina_recovery = -1
Can just remove if( stamina_multiplier > 0.0f ) {
and instead clamp stamina_recovery to 0+ after applying encumbrance.
There was a problem hiding this comment.
The if was redundant and removed, and the negative thing has the max check between 1 and ( base recovery - mouth encumbrance / 10 ) on it, meaning that it would solve out to a absolute minimum of 0.1 or 1.7 in your example.
|
Having fun while playing a game is more important than playing a "realistic" game. |
SUMMARY: Balance "Edits the winded effect to make more sense and not permalock the player"Purpose of change
Fixes #31889 Fixes #31907
Describe the solution
Rebalances the winded effect to not redundantly reduce hunger, thirst, and fatigue as is already done by the player activity level, caps the pain level to prevent locking a player down into more pain than any hulk or gun could hope to accomplish, and also increasing the movement penalty because of these.
also allows very slight stamina regen while winded to prevent being locked into winded at 0 stamina.
Additional context
Player reported pain from being gutpunched by a hulk is ~40, so i set the cap to about half of that. Being incapable of running does not decrease your hunger, fatigue, or thirst, those should already be decreased by the stamina draining activity.