Correct coordinate handling for active item cache #32376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was using abs_sub inapropriately to convert between absolute and local coordinates. Only x and y coordinates need conversion, z does not. Also map::get_active_items_in_radius() was failing to convert entirely.
kevingranade
force-pushed
the
fix-active-item-cache
branch
from
38c7dc8
to
bbf6f77
Compare
kevingranade
changed the title
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: None
Purpose of change
Fixes #32341
Fixes #32133
These are both due to bugs in coordinate handling for submaps_with_active_items.
Describe the solution
Fix coordinate handling.
Testing
Underground item processing is unreliable because the previous code adds or subtracts map::abs_sub::z from the local submap coordinates. To test go underground or aboveground and fling smoke bombs (safer than grenades).
To test pulping, just spawn a zombie and a NPC and kill the zombie, be sre to check underground too.