Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 5 new backpacks #32914

Merged
merged 10 commits into from Aug 7, 2019
Merged

Adds 5 new backpacks #32914

merged 10 commits into from Aug 7, 2019

Conversation

Hymore246
Copy link
Contributor

Summary

SUMMARY: Content "Adds 5 new backpacks"

Purpose of change

Fixes #32332
Adds 5 new backpacks of various sizes to the game.

Describe the solution

This change adds 5 new backpacks and recipes, Below are the details for the new backpacks:

Name Encumbrance Storage (L) Special
high-volume rucksack 60 100.00
hiking pack 35 55.00 Activate to sheath up to 2 small knifes/swords
large tactical backpack 45 65.00
petpack 14 3.75 Activated to store a small creature (cat, chicken, etc) inside just like a pet carrier
travelpack 14 25.00

Describe alternatives you've considered

I think the encumbrance and storage are balanced but I'm open to other opinions. As far as I know, encumbrance as a whole needs an overhaul but I'll adjust the items as necessary.

Additional context

I did not come up with the idea for these backpacks. The user "ghost" created these backpack in #32426. However, ghost has delete their account and closed the PR for some unknown reason. I did not want to see a good idea go to waste, so I'm adding them in myself.

@ghost
Copy link

ghost commented Aug 4, 2019

As I know @anothersimulacrum will request once he sees this, can you change the formatting of their volumes to the milliliter/liter format?

data/json/items/armor.json Outdated Show resolved Hide resolved
data/json/items/armor.json Outdated Show resolved Hide resolved
data/json/items/armor.json Outdated Show resolved Hide resolved
data/json/items/armor.json Outdated Show resolved Hide resolved
data/json/items/armor.json Outdated Show resolved Hide resolved
@ampersand55
Copy link
Contributor

I think the current backpacks need to be rebalanced in relation to these.

E.g. the travelpack has the same storage as the survivor rucksack (25L), but is much better.

The survivor rucksack is higher encumbrance, lower armor, higher coverage, higher skill requirements requires more materials to craft, not waterproof, heavier and takes up more space.

The normal backpack, the military rucksack and the duffelbag seem to be able to store encumbrance x 4 units of 250ml.

The survivor backpack and the survivor rucksack seem to be able to store encumbrance x 5 + 10 units of 250ml, and the survivor duffelbag is a little better.

A table:

Item Current encumbrance Normal encumbrance High-end "survivor" encumbrance Storage
high-volume rucksack 60 100 78 100L
hiking pack 35 55 42 55L
large tactical backpack 45 65 50 65L
travelpack 14 25 18 25L
backpack 10 10 6 10L
military rucksack 20 20 14 20L
duffel bag 30 30 22 30L
survivor backpack 8 12.5 8 12.5L
survivor rucksack 18 25 18 25L
survivor duffelbag 25 37.5 (28) 37.5L

Copy link
Contributor

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, whoops, missed that comment from LaVeyan. Jenkins seems to just be having problems today.

data/json/items/armor.json Outdated Show resolved Hide resolved
Hymore246 and others added 6 commits August 4, 2019 15:45
Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
@Hymore246
Copy link
Contributor Author

I think the current backpacks need to be rebalanced in relation to these.

I agree and there should probably be a few more containers added too. But that's outside the scope of this PR.

@ampersand55
Copy link
Contributor

I think the current backpacks need to be rebalanced in relation to these.

I agree and there should probably be a few more containers added too. But that's outside the scope of this PR.

Adjusting the encumbrance to be the same as the storage in L would be enough to make them consistent with the current backpacks and imho mergable.

@Hymore246
Copy link
Contributor Author

I think the current backpacks need to be rebalanced in relation to these.

I agree and there should probably be a few more containers added too. But that's outside the scope of this PR.

Adjusting the encumbrance to be the same as the storage in L would be enough to make them consistent with the current backpacks and imho mergable.

Yeah, that seems fair. Most containers seem to follow that trend. There should probably be another PR in the future to rethink the standard formula.

@Cyrano7 Cyrano7 added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Aug 4, 2019
"type": "holster",
"holster_prompt": "Sheath blade",
"holster_msg": "You sheath your %s",
"min_volume": 1,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"min_volume": 1,
"min_volume": "250ml",

I'm honestly not sure if min_volume and max_volume accept the milliliter/liter format.

Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
@l29ah
Copy link
Contributor

l29ah commented Aug 5, 2019

Re encumbrance: #32332 (comment)

@ZhilkinSerg ZhilkinSerg self-assigned this Aug 6, 2019
data/json/items/armor.json Outdated Show resolved Hide resolved
Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
@ZhilkinSerg ZhilkinSerg merged commit 9f46f66 into CleverRaven:master Aug 7, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Aug 7, 2019
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* Adds 5 new backpacks

* Update data/json/items/armor.json

Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>

* Update data/json/items/armor.json

Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>

* Update data/json/items/armor.json

Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>

* Update data/json/items/armor.json

Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>

* Update data/json/items/armor.json

Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>

* Yellow is the new Orange

* Encumbrance adjustments

* Update data/json/items/armor.json

Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>

* Update data/json/items/armor.json

Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Available backpacks are too small
6 participants