New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 5 new backpacks #32914
Adds 5 new backpacks #32914
Conversation
As I know @anothersimulacrum will request once he sees this, can you change the formatting of their volumes to the milliliter/liter format? |
I think the current backpacks need to be rebalanced in relation to these. E.g. the travelpack has the same storage as the survivor rucksack (25L), but is much better. The survivor rucksack is higher encumbrance, lower armor, higher coverage, higher skill requirements requires more materials to craft, not waterproof, heavier and takes up more space. The normal backpack, the military rucksack and the duffelbag seem to be able to store encumbrance x 4 units of 250ml. The survivor backpack and the survivor rucksack seem to be able to store encumbrance x 5 + 10 units of 250ml, and the survivor duffelbag is a little better. A table:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, whoops, missed that comment from LaVeyan. Jenkins seems to just be having problems today.
Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
I agree and there should probably be a few more containers added too. But that's outside the scope of this PR. |
Adjusting the encumbrance to be the same as the storage in L would be enough to make them consistent with the current backpacks and imho mergable. |
Yeah, that seems fair. Most containers seem to follow that trend. There should probably be another PR in the future to rethink the standard formula. |
data/json/items/armor.json
Outdated
"type": "holster", | ||
"holster_prompt": "Sheath blade", | ||
"holster_msg": "You sheath your %s", | ||
"min_volume": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"min_volume": 1, | |
"min_volume": "250ml", |
I'm honestly not sure if min_volume and max_volume accept the milliliter/liter format.
Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
Re encumbrance: #32332 (comment) |
Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
* Adds 5 new backpacks * Update data/json/items/armor.json Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com> * Update data/json/items/armor.json Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com> * Update data/json/items/armor.json Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com> * Update data/json/items/armor.json Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com> * Update data/json/items/armor.json Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com> * Yellow is the new Orange * Encumbrance adjustments * Update data/json/items/armor.json Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com> * Update data/json/items/armor.json Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
Summary
SUMMARY: Content "Adds 5 new backpacks"
Purpose of change
Fixes #32332
Adds 5 new backpacks of various sizes to the game.
Describe the solution
This change adds 5 new backpacks and recipes, Below are the details for the new backpacks:
Describe alternatives you've considered
I think the encumbrance and storage are balanced but I'm open to other opinions. As far as I know, encumbrance as a whole needs an overhaul but I'll adjust the items as necessary.
Additional context
I did not come up with the idea for these backpacks. The user "ghost" created these backpack in #32426. However, ghost has delete their account and closed the PR for some unknown reason. I did not want to see a good idea go to waste, so I'm adding them in myself.