Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MBR vest price #34157

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Fix MBR vest price #34157

merged 1 commit into from
Sep 21, 2019

Conversation

eltank
Copy link
Contributor

@eltank eltank commented Sep 21, 2019

Summary

SUMMARY: Bugfixes "Fix MBR vest price"

Purpose of change

PR #34109 accidentally increased the post-apoc price of MBR vest by a factor of 10 (to $10000). I know it's accidental because: a) the old price was $1000, b) enhanced MBR vest variants are still in the $1000 to $2000 price range, and c) it's just ridiculously high compared to everything else.

Describe the solution

Reduce price by 10x, back to what it was before PR #34109.

Describe alternatives you've considered

Keeping this knowledge to myself and exploiting the hell out of it.

Additional context

This sort of mistake would be less likely to happen if we didn't express all prices in cents. Too many zeroes, hard to read.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Sep 21, 2019
@ZhilkinSerg ZhilkinSerg merged commit 178117c into CleverRaven:master Sep 21, 2019
@eltank eltank deleted the fix-mbr-price branch November 26, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants