Skip sunlight calculation on uniform z-levels #34391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
|
wait, sunlight is raycasted in this game? neato. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "Skip sunlight calculation on uniform z-levels"Purpose of change
Raycasting is unnecessarily done from the top of the sky. To avoid this, sunlight begins at the highest populated z-level in the reality bubble.
Describe the solution
On map::shift() the highest z-level of the current submaps is calculated and recorded in the level_cache to be used as an upper bound for suncasting.
Describe alternatives you've considered
Might be a better way to do this, but 馃し
Additional context
Closes #34348