Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regularize ammunition naming #34618

Merged
merged 6 commits into from
Nov 25, 2019
Merged

Conversation

Muffindrake
Copy link
Contributor

@Muffindrake Muffindrake commented Oct 10, 2019

Summary

SUMMARY: Interface "Regularize ammunition naming"

Purpose of change

In an alphanumeric listing of items, the location of ammunition of the same type is all over the place, and very often not even on the same screen if there happen to be non-ammunition items among them. The ammunition named reloaded is a particularly bad offender in this, the unfortunate choice of the letter r ensuring it ends up at the end of multi-page item listings, ludicrously far away from the ammo that usually starts with a period.

Describe the solution

Change all reloaded and blackpowder variants of ammunition to use a scheme type (comma-separated list of modifiers), e.g. 00 shot (reloaded, blackpowder).

Describe alternatives you've considered

Different naming schemes:
type, comma separated list of modifiers

type (modifier1) (modifier2)

Additional context

before
after

Make it so that for ammunition names, the type always comes first, with
any modifiers such as 'reloaded' or 'blackpowder' following the type in
parentheses.
@ZhilkinSerg
Copy link
Contributor

Poor translators xD

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items / Item Actions / Item Qualities Items and how they work and interact Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA labels Oct 10, 2019
Copy link
Contributor

@Davi-DeGanne Davi-DeGanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parentheses in item names typically indicate transient or reversible properties -- (frozen), (wet), (hot), and (padded), to name a few. I suggest doing

00 shot, reloaded
00 shot, blackpowder

for the sake of consistency.

@Muffindrake
Copy link
Contributor Author

Parentheses in item names typically indicate transient or reversible properties -- (frozen), (wet), (hot), and (padded), to name a few. I suggest doing

00 shot, reloaded
00 shot, blackpowder

for the sake of consistency.

I fully agree. I had done it the current way because some dev in the dev discord had some trepidations about the commas for some reason. I much preferred doing this type of scheme to begin with.

@esotericist
Copy link
Contributor

Parentheses in item names typically indicate transient or reversible properties -- (frozen), (wet), (hot), and (padded), to name a few. I suggest doing

00 shot, reloaded
00 shot, blackpowder

for the sake of consistency.

I fully agree. I had done it the current way because some dev in the dev discord had some trepidations about the commas for some reason. I much preferred doing this type of scheme to begin with.

Bit belated, but do you remember any other details about which dev had which concern about the commas? I'm not able to find anything about that.

Copy link
Member

@ymber ymber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good UX improvement. There are two mistakes in the strings to deal with. I'd like to get this in before 0E.

data/json/items/ammo/223.json Show resolved Hide resolved
data/json/items/ammo/4570.json Outdated Show resolved Hide resolved
@Muffindrake
Copy link
Contributor Author

There is no actual word blackpowder in any English dictionary I know of, so I'm changing all occurrences to black powder as it should be.

@kevingranade kevingranade merged commit d05d1d1 into CleverRaven:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants