clang-tidy: fix error in 'clang-tidy CMake build with Tiles and Sound' #34947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes error: Construction of 'tripoint' can be simplified using
overloaded arithmetic operators.
[cata-use-point-arithmetic,-warnings-as-errors]
Suggested fix by error output is to use:
const tripoint &pt = tripoint_zero + tripoint(
delta_x * wall_size,
delta_y * wall_size,
delta_z );
tripoint_zero is defined as tripoint(0, 0, 0), so arithmetic operations
would simplify further to just:
const tripoint &pt(
delta_x * wall_size,
delta_y * wall_size,
delta_z );
Further, while it does not cause an error to use a const reference here
it is unnecessary.
ZhilkinSerg
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Fix an error causing testing build
clang-tidy CMake build with Tiles and Soundto failDescribe the solution
Because
tripoint_zerois defined astripoint( 0, 0, 0 )it is entirely unnecessary to the calculation of the points generating the error and allows simplification of the calculation.Also changed from
const tripoint &toconst tripoint. While not an compile error to use a const reference here it is unnecessary.Additional context
Looks like the bug was introduced during #34866