Free Merchants - new NPC classes and a trading post [help needed/almost done]

[Brytenwalda]

Summary

SUMMARY: Content "A garage trading post with a merchant and two guards."

Purpose of change

I believe that the game needs more trading outposts where players can exchange items. We already have a faction to do it, why not expand it a bit?

Overall, this should add another level of plausibility to this world - a traveling merchant who brings various individuals - hunters, fishermen, scavengers, and other survivors together through trade.

Describe the solution

1. Two new NPC classes - a field merchant and a guard.
2. A new mapgen building - a copy of the existing garage, but with the merchant and two guards in it.
3. I added the new trader garage to the regional map settings file, with a reasonably low chance to spawn.

Problem

As of this moment, the game fails to recognize the new NPC classes that I've added to classes.json. I would greatly appreciate any help to make them work .

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/new-npcs-i-need-your-help/21800/1

[Night-Pryanik]

Your created roof (1s_garage__trader_roof, btw why there are two underscores between garage and trader?) won't spawn at all. You need to created a new entry with your ground floor and your roof in any fitting json in \data\json\overmap\overmap_terrain\. Also you need to create a new entry in \data\json\overmap\multitile_city_buildings.json for both of your ground floor and your roof.